linux-kernel - Re: [PATCH] smb: Use arc4 library instead of duplicate arc4 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ad540512e8527bddcb474bd7c1f9f6b@manguebit.org>
Date: Sun, 07 Sep 2025 23:39:10 -0300
From: Paulo Alcantara <pc@...guebit.org>
To: Eric Biggers <ebiggers@...nel.org>, linux-cifs@...r.kernel.org, Steve
 French <sfrench@...ba.org>, Namjae Jeon <linkinjeon@...nel.org>
Cc: Ronnie Sahlberg <ronniesahlberg@...il.com>, Shyam Prasad N
 <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>, Bharath SM
 <bharathsm@...rosoft.com>, Sergey Senozhatsky <senozhatsky@...omium.org>,
 linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, Eric Biggers
 <ebiggers@...nel.org>
Subject: Re: [PATCH] smb: Use arc4 library instead of duplicate arc4 code

Eric Biggers <ebiggers@...nel.org> writes:

> fs/smb/common/cifs_arc4.c has an implementation of ARC4, but a copy of
> this same code is also present in lib/crypto/arc4.c to serve the other
> users of this legacy algorithm in the kernel.  Remove the duplicate
> implementation in fs/smb/, which seems to have been added because of a
> misunderstanding, and just use the lib/crypto/ one.
>
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  fs/smb/client/Kconfig       |  1 +
>  fs/smb/client/cifsencrypt.c |  8 ++--
>  fs/smb/common/Makefile      |  1 -
>  fs/smb/common/arc4.h        | 23 ------------
>  fs/smb/common/cifs_arc4.c   | 75 -------------------------------------
>  fs/smb/server/Kconfig       |  1 +
>  fs/smb/server/auth.c        |  9 ++---
>  7 files changed, 10 insertions(+), 108 deletions(-)
>  delete mode 100644 fs/smb/common/arc4.h
>  delete mode 100644 fs/smb/common/cifs_arc4.c

Reviewed-by: Paulo Alcantara (Red Hat) <pc@...guebit.org>