linux-kernel - Re: [PATCH v2 2/2] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <307a76a6-cc92-44a1-9ac0-97005bf51b4b@lunn.ch>
Date: Tue, 9 Sep 2025 14:31:28 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Kaison Deng <dkx@...hip.com.cn>
Cc: Rob Herring <robh@...nel.org>, Jimmy Hon <honyuenkwun@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>, Wayne Chou <zxf@...hip.com.cn>,
	Quentin Schulz <quentin.schulz@...rry.de>,
	Dragan Simic <dsimic@...jaro.org>, Jonas Karlman <jonas@...boo.se>,
	FUKAUMI Naoki <naoki@...xa.com>,
	Peter Robinson <pbrobinson@...il.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add devicetree for the
 ROC-RK3588-RT

> - 2x Gigabit Ethernet, 1x 2.5G Ethernet

I actually only see the 2x 1G. Is the 2.5G not supported yet?

> +&gmac0 {
> +	clock_in_out = "output";
> +	phy-handle = <&rgmii_phy0>;
> +	phy-mode = "rgmii-rxid";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac0_miim
> +		     &gmac0_tx_bus2
> +		     &gmac0_rx_bus2
> +		     &gmac0_rgmii_clk
> +		     &gmac0_rgmii_bus>;
> +	tx_delay = <0x47>;

What happened about my comment that "rgmii-rxid" is probably wrong?

If you think it is correct, you should reply with a
justification. Maybe PCB is very odd? In which case, a comment would
be good to explain who it is odd.

	Andrew