linux-kernel - Re: [PATCH v4 08/19] tools/docs: sphinx-build-wrapper: add a wrapper for sphinx-build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ldmnwt1c.fsf@trenco.lwn.net>
Date: Tue, 09 Sep 2025 09:21:35 -0600
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Alex Gaynor <alex.gaynor@...il.com>, Alice
 Ryhl <aliceryhl@...gle.com>, Andreas Hindborg <mchehab+huawei@...nel.org>,
 Benno Lossin <mchehab+huawei@...nel.org>, Boqun Feng
 <boqun.feng@...il.com>, Danilo Krummrich <mchehab+huawei@...nel.org>, Gary
 Guo <gary@...yguo.net>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
 Miguel Ojeda <mchehab+huawei@...nel.org>, Trevor Gross
 <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v4 08/19] tools/docs: sphinx-build-wrapper: add a
 wrapper for sphinx-build

Another nit:

>         # sphinxdirs can be a list or a whitespace-separated string
>         #
>         sphinxdirs_list = []
>         for sphinxdir in sphinxdirs:
>             if isinstance(sphinxdir, list):
>                 sphinxdirs_list += sphinxdir
>             else:
>                 for name in sphinxdir.split(" "):
>                     sphinxdirs_list.append(name)

That inner loop just seems like a complicated way of saying:

	sphinxdirs_list += sphinxdir.split()

?

Thanks,

jon