linux-kernel - Re: [PATCH v9 05/31] x86,fs/resctrl: Improve domain type checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d947f2b7-e2ea-4ebe-978f-73ee6d674567@intel.com>
Date: Tue, 9 Sep 2025 14:12:21 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v9 05/31] x86,fs/resctrl: Improve domain type checking

Hi Tony,

On 8/29/25 12:33 PM, Tony Luck wrote:
> The rdt_domain_hdr structure is used in both control and monitor
> domain structures to provide common methods for operations such as
> adding a CPU to a domain, removing a CPU from a domain, accessing
> the mask of all CPUs in a domain.
> 
> rdt_domain_hdr::type provides a simple check whether a domain is a
> control or monitor domain so that programming errors operating
> on domains will be quickly caught. This is insufficient to
> catch errors when other resources besides L3 support monitor
> events.
> 
> Add rdt_domain_hdr::rid to contain the resource id and initialize it
> as part of domain structure allocation done by CPU online handler. Call
> domain_header_is_valid() to sanity check both the type and resource id
> before using container_of() to get a pointer to the associated domain.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette