linux-kernel - Re: [PATCH] gpio: mpsse: support bryx radio interface kit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McBdJ16RYvJM_R7pL+u3zcs_+A0nj5_5twP7KxWhW6VDw@mail.gmail.com>
Date: Wed, 10 Sep 2025 15:15:46 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org, 
	oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH] gpio: mpsse: support bryx radio interface kit

On Wed, Sep 10, 2025 at 2:47 PM Mary Strodl <mstrodl@....rit.edu> wrote:
>
> On Tue, Sep 09, 2025 at 09:32:09PM +0800, kernel test robot wrote:
> >    drivers/gpio/gpio-mpsse.c: In function 'mpsse_ensure_supported':
> > >> drivers/gpio/gpio-mpsse.c:211:25: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
> >      211 |                         "mpsse: GPIO %ld doesn't support %s\n",
> >          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Oops. Turns out this is m68k-specific weirdness. v2 will convert the
> result to an int and use %d.
>
> I'll hold off on posting it because I'm anticipating there will be some feedback
> on the actual code changes that will need a revision anyways ;)

I cannot really give you much feedback because this patch should be
first split into smaller chunks that explain what each change is
doing. As it is: it's so complex, I simply don't understand it and
don't have enough time to try and decipher it. Please try to make it
into a series of smaller patches.

Bartosz