linux-kernel - Re: [PATCH] ASoC: amd: acp: Fix incorrect retrival of acp_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2f8e45e-c289-4649-b764-8ded15f0bb16@intel.com>
Date: Wed, 10 Sep 2025 15:53:29 +0200
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: "Prasad, Prasad" <venkataprasad.potturu@....com>
CC: "Mukunda, Vijendar" <Vijendar.Mukunda@....com>, "Hiregoudar, Basavaraj"
	<Basavaraj.Hiregoudar@....com>, "Dommati, Sunil-kumar"
	<Sunil-kumar.Dommati@....com>, "Saba Kareem, Syed" <Syed.SabaKareem@....com>,
	Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Greg KH <gregkh@...uxfoundation.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>, Ranjani Sridharan
	<ranjani.sridharan@...ux.intel.com>, Peter Zijlstra <peterz@...radead.org>,
	Daniel Baluta <daniel.baluta@....com>, "open list:SOUND - SOC LAYER / DYNAMIC
 AUDIO POWER MANAGEM..." <linux-sound@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>, "broonie@...nel.org" <broonie@...nel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: amd: acp: Fix incorrect retrival of acp_chip_info

On 2025-09-10 3:39 PM, Prasad, Prasad wrote:
> 
> On 9/10/2025 2:41 PM, Cezary Rojewski wrote:
>> On 2025-09-09 8:19 AM, Venkata Prasad Potturu wrote:
>>> Use dev_get_drvdata(dev->parent) instead of dev_get_platdata(dev)
>>> to correctly get acp_chip_info members in acp I2S driver.
>>> This resolves issues where some members were zero due to incorrect
>>> data access.
>>
>> Hi,
>>
>> 'some members were zero' meaning null-ptr-deref? If so, please reword
>> to make it more explicit.
> It's not a null-ptr-deref, members were not updated properly, will
> rephrase the commit description
>>
>> Given the history of this file, mainly Commit 6d9b64156d84 ("ASoC:
>> amd: acp: Fix NULL pointer deref in acp_i2s_set_tdm_slot") it's kind
>> of surprising that the issue is addressed in staggered fashion. Why
>> was set_tdm_slot() fixed separately?
> This fix was missed earlier at the time of this commit 6d9b64156d84.

Let's mention that in the commit message then. It's clear now that the 
earlier fix is insufficient and null-ptr-derefs may still occur.

>>
>>> Fixes: e3933683b25e ("ASoC: amd: acp: Remove redundant acp_dev_data
>>> structure")
>>>
>>> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@....com>
>>
>> No newline between the tags, please.
> Okay, will send v2 patch.