linux-kernel - Re: [PATCH v7 00/24] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMGOgHzwig8NvxT-@kekkonen.localdomain>
Date: Wed, 10 Sep 2025 17:43:12 +0300
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Cosmin Tanislav <cosmin.tanislav@...log.com>,
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Niklas Söderlund <niklas.soderlund@...natech.se>,
	Julien Massot <julien.massot@...labora.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-staging@...ts.linux.dev, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v7 00/24] media: i2c: add Maxim GMSL2/3 serializer and
 deserializer drivers

Hi Cosmin,

On Wed, Sep 10, 2025 at 01:48:29PM +0300, Cosmin Tanislav wrote:
> 
> 
> On 9/10/25 9:52 AM, Sakari Ailus wrote:
> > Hi Cosmin,
> > 
> > On Thu, Sep 04, 2025 at 10:52:09AM +0300, Cosmin Tanislav wrote:
> > > Hi Sakari.
> > > 
> > > I recently left Analog Devices but I will continue to try upstreaming
> > > this driver. After the upstreaming is done we can switch the
> > > maintainer status to someone else.
> > 
> > Ack, thank you.
> > 
> > > 
> > > Here's the output for the commands you asked, provided by my
> > > ex-coworker. It's for MAX96716 + 2xMAX96717 + 2x IMX219.
> > > 
> > > Do we need to fix anything based on the compliance tests?
> > 
> > Looking at the errors, it looks like some fixing is needed, possibly also
> > on v4l2-compliance side.
> > 
> 
> I'll take a closer look at the failures whenever I get the time.
> 
> > Regarding GMSL, are the image width, height or mbus code used for anything
> > by the serialiser or deserialiser drivers?
> > 
> 
> No, not really. All the information needed by the GMSL drivers is
> provided through get_frame_desc() ops, and there's no fallback for the
> data type, so the stream format is not involved at all, but as far as I
> remember it's necessary to be set properly for the media pipeline to
> pass validation.

In earlier iterations of multi-stream support we've had link validation dig
this information up from the closest sub-device that supported get_fmt pad
op but that also made the assumption there would be no stream branching
taking place, which is not the case anymore.

I guess the most simple way to address this indeed would be to add the
formats to the streams, even if the driver doesn't need them. Also for
backwards compatiblity related reasons they are probably necessary -- the
older max9671* drivers did support them, too.

This would also address (most of?) the v4l2-compliance issues.

-- 
Kind regards,

Sakari Ailus