linux-kernel - Re: [PATCH 1/2] x86/hw_breakpoint: Unify breakpoint install/uninstall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <332DA932-2A5A-48B1-AEF6-84D4CCDB7BA1@zytor.com>
Date: Wed, 10 Sep 2025 07:56:44 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Dave Hansen <dave.hansen@...el.com>,
        Jinchao Wang <wangjinchao600@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
CC: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86/hw_breakpoint: Unify breakpoint install/uninstall

On September 10, 2025 7:47:06 AM PDT, Dave Hansen <dave.hansen@...el.com> wrote:
>On 9/10/25 02:39, Jinchao Wang wrote:
>> Consolidate breakpoint management into a single helper function to
>> reduce code duplication. This introduces new static helpers for
>> slot management and debug register manipulation.
>> 
>> Also, add `<linux/types.h>` to the header file to fix a build
>> dependency.
>> 
>> Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>
>> ---
>>  arch/x86/include/asm/hw_breakpoint.h |   7 +-
>>  arch/x86/kernel/hw_breakpoint.c      | 151 ++++++++++++++++-----------
>>  2 files changed, 96 insertions(+), 62 deletions(-)
>
>That diffstat doesn't look like it's reducing code duplication.

He does add a *lot* of comments.