linux-kernel - Re: [PATCH 12/32] uts: use ns_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <infsybiodcbptlbolgls6jpur674rszsvdjee6iylcqhq3m5jq@jdmi6vhn2ctf>
Date: Wed, 10 Sep 2025 17:46:27 +0200
From: Jan Kara <jack@...e.cz>
To: Christian Brauner <brauner@...nel.org>
Cc: Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>, 
	linux-fsdevel@...r.kernel.org, Josef Bacik <josef@...icpanda.com>, 
	Jeff Layton <jlayton@...nel.org>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering <mzxreary@...inter.de>, 
	Daan De Meyer <daan.j.demeyer@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Chuck Lever <chuck.lever@...cle.com>, linux-nfs@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH 12/32] uts: use ns_common_init()

On Wed 10-09-25 16:36:57, Christian Brauner wrote:
> Don't cargo-cult the same thing over and over.
> 
> Signed-off-by: Christian Brauner <brauner@...nel.org>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  kernel/utsname.c | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/kernel/utsname.c b/kernel/utsname.c
> index b1ac3ca870f2..02037010b378 100644
> --- a/kernel/utsname.c
> +++ b/kernel/utsname.c
> @@ -27,16 +27,6 @@ static void dec_uts_namespaces(struct ucounts *ucounts)
>  	dec_ucount(ucounts, UCOUNT_UTS_NAMESPACES);
>  }
>  
> -static struct uts_namespace *create_uts_ns(void)
> -{
> -	struct uts_namespace *uts_ns;
> -
> -	uts_ns = kmem_cache_alloc(uts_ns_cache, GFP_KERNEL);
> -	if (uts_ns)
> -		refcount_set(&uts_ns->ns.count, 1);
> -	return uts_ns;
> -}
> -
>  /*
>   * Clone a new ns copying an original utsname, setting refcount to 1
>   * @old_ns: namespace to clone
> @@ -55,17 +45,15 @@ static struct uts_namespace *clone_uts_ns(struct user_namespace *user_ns,
>  		goto fail;
>  
>  	err = -ENOMEM;
> -	ns = create_uts_ns();
> +	ns = kmem_cache_zalloc(uts_ns_cache, GFP_KERNEL);
>  	if (!ns)
>  		goto fail_dec;
>  
> -	err = ns_alloc_inum(&ns->ns);
> +	err = ns_common_init(&ns->ns, &utsns_operations, true);
>  	if (err)
>  		goto fail_free;
>  
>  	ns->ucounts = ucounts;
> -	ns->ns.ops = &utsns_operations;
> -
>  	down_read(&uts_sem);
>  	memcpy(&ns->name, &old_ns->name, sizeof(ns->name));
>  	ns->user_ns = get_user_ns(user_ns);
> 
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR