linux-kernel - Re: [PATCH v4 6/6] perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c675681-e15f-4b94-b567-6545ac4cfa06@arm.com>
Date: Wed, 10 Sep 2025 17:29:55 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Alireza Sanaee <alireza.sanaee@...wei.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: coresight@...ts.linaro.org, dianders@...omium.org,
 james.clark@...aro.org, jonathan.cameron@...wei.com, krzk@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-perf-users@...r.kernel.org,
 linuxarm@...wei.com, mark.rutland@....com, mike.leach@...aro.org,
 robh@...nel.org, ruanjinjie@...wei.com, saravanak@...gle.com
Subject: Re: [PATCH v4 6/6] perf/arm-dsu: refactor cpu id retrieval via new
 API of_cpu_phandle_to_id

On 05/09/2025 17:18, Alireza Sanaee wrote:
> Update arm-dsu to use the new API (of_cpu_phandle_to_id).
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@...wei.com>
> ---
>   drivers/perf/arm_dsu_pmu.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
> index cb4fb59fe04b..8f76bd94349c 100644
> --- a/drivers/perf/arm_dsu_pmu.c
> +++ b/drivers/perf/arm_dsu_pmu.c
> @@ -591,17 +591,12 @@ static struct dsu_pmu *dsu_pmu_alloc(struct platform_device *pdev)
>   static int dsu_pmu_dt_get_cpus(struct device *dev, cpumask_t *mask)
>   {
>   	int i = 0, n, cpu;
> -	struct device_node *cpu_node;
>   
>   	n = of_count_phandle_with_args(dev->of_node, "cpus", NULL);
>   	if (n <= 0)
>   		return -ENODEV;
>   	for (; i < n; i++) {
> -		cpu_node = of_parse_phandle(dev->of_node, "cpus", i);
> -		if (!cpu_node)
> -			break;
> -		cpu = of_cpu_node_to_id(cpu_node);
> -		of_node_put(cpu_node);
> +		cpu = of_cpu_phandle_to_id(dev->of_node, NULL, i);
>   		/*
>   		 * We have to ignore the failures here and continue scanning
>   		 * the list to handle cases where the nr_cpus could be capped

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>