linux-kernel - Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver for handling CXL RCH errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7d395e1-b5f2-4897-a6f0-4d503e0fcb66@amd.com>
Date: Wed, 10 Sep 2025 12:01:56 -0500
From: "Bowman, Terry" <terry.bowman@....com>
To: Lukas Wunner <lukas@...ner.de>, Dave Jiang <dave.jiang@...el.com>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dan.j.williams@...el.com,
 bhelgaas@...gle.com, shiju.jose@...wei.com,
 sathyanarayanan.kuppuswamy@...ux.intel.com, linux-cxl@...r.kernel.org,
 alucerop@....com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver
 for handling CXL RCH errors



On 8/29/2025 3:39 AM, Lukas Wunner wrote:
> On Thu, Aug 28, 2025 at 01:53:35PM -0700, Dave Jiang wrote:
>> On 8/26/25 6:35 PM, Terry Bowman wrote:
>>>  drivers/cxl/Kconfig        |   9 +++-
>>>  drivers/cxl/core/ras.c     |   3 ++
>>>  drivers/pci/pci.h          |  20 +++++++
>>>  drivers/pci/pcie/Makefile  |   1 +
>>>  drivers/pci/pcie/aer.c     | 108 +++----------------------------------
>>>  drivers/pci/pcie/rch_aer.c |  99 ++++++++++++++++++++++++++++++++++
>> I wonder if this should be cxl_rch_aer.c to be clear that it's cxl
>> related code.
> I'd prefer an "aer_" prefix at the beginning of filenames,
> but maybe that's just me...
>
> Thanks,
>
> Lukas
You guys let me know what to rename it to. I'm fine with either 
change: cxl_rch_aer.c or aer_cxl_rch.c.

We also have the VH analog of this file currently named pcie/cxl_aer.c. 
This is introduced in patch 17, CXL/AER: 
'Introduce cxl_aer.c into AER driver for forwarding CXL errors'.

We may need to make similar change to the VH file name as well to 
be consistent.

Regards,
Terry