linux-kernel - Re: [PATCH v2 1/2] tpm: Compare HMAC values in constant time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMGxG4BSc0UgXqxl@kernel.org>
Date: Wed, 10 Sep 2025 20:10:51 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Peter Huewe <peterhuewe@....de>, linux-integrity@...r.kernel.org,
	Jason Gunthorpe <jgg@...pe.ca>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tpm: Compare HMAC values in constant time

On Wed, Sep 03, 2025 at 07:38:28PM -0700, Eric Biggers wrote:
> Hi Jarkko,
> 
> On Sat, Aug 09, 2025 at 10:38:39AM -0700, Eric Biggers wrote:
> > On Sat, Aug 09, 2025 at 01:36:46PM +0300, Jarkko Sakkinen wrote:
> > > On Tue, Aug 05, 2025 at 09:07:40AM -0700, Eric Biggers wrote:
> > > > On Tue, Aug 05, 2025 at 04:50:17PM +0300, Jarkko Sakkinen wrote:
> > > > > 
> > > > > I think we might want to also backport this to stables.
> > > > > 
> > > > 
> > > > That's what I did originally, but on v1 James complained about it being
> > > > characterized as a fix.
> > > 
> > > Please put out v3 with backporting shenanigans and I can apply these.
> > > 
> > 
> > v1 had Fixes and Cc stable
> > (https://lore.kernel.org/r/20250731215255.113897-2-ebiggers@kernel.org/).
> > Again, I removed them in response to James' complaint about it being
> > characterized as a fix.  If you want them back, please go ahead and add
> > them back in when committing.  I'm not going to go around in circles.
> > 
> > - Eric
> 
> Could you let me know how you'd like to proceed here?  Thanks.

Thanks for reminding. I applied them to my local tree and will push
tomorrow.

> 
> - Eric

BR, Jarkko