linux-kernel - Re: [PATCH 2/3] mm: remove unused zpool layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250910031421.166611-1-sj@kernel.org>
Date: Tue,  9 Sep 2025 20:14:21 -0700
From: SeongJae Park <sj@...nel.org>
To: Johannes Weiner <hannes@...xchg.org>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Yosry Ahmed <yosryahmed@...gle.com>,
	Nhat Pham <nphamcs@...il.com>,
	Chengming Zhou <zhouchengming@...edance.com>,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mm: remove unused zpool layer

On Tue, 9 Sep 2025 16:13:45 +0100 Johannes Weiner <hannes@...xchg.org> wrote:

> On Fri, Aug 29, 2025 at 12:07:28PM -0700, SeongJae Park wrote:
> > On Fri, 29 Aug 2025 17:15:27 +0100 Johannes Weiner <hannes@...xchg.org> wrote:
> > 
> > > With zswap using zsmalloc directly, there are no more in-tree users of
> > > this code. Remove it.
> > > 
> > > Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> > [...]
> > > --- a/Documentation/admin-guide/mm/zswap.rst
> > > +++ b/Documentation/admin-guide/mm/zswap.rst
> > [...]
> > >  When a swap page is passed from swapout to zswap, zswap maintains a mapping
> > > -of the swap entry, a combination of the swap type and swap offset, to the zpool
> > > -handle that references that compressed swap page.  This mapping is achieved
> > > -with a red-black tree per swap type.  The swap offset is the search key for the
> > > -tree nodes.
> > 
> > Nit.  s/red-black tree/xarray/ ?
> 
> Yeah, I just kept the changes scoped to the removal of zpool.

Makes sense to me :)

> 
> But this file indeed needs a general update beyond the changes in this
> series. I'll send a separate patch to clean this up.

Looking forward to!

> 
> > Acked-by: SeongJae Park <sj@...nel.org>
> 
> Thanks SJ

:)


Thanks,
SJ