linux-kernel - Re: [PATCH 3/4] media: i2c: ds90ub953: use devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMH8pxaiKvjW8dw/@lizhi-Precision-Tower-5810>
Date: Wed, 10 Sep 2025 18:33:11 -0400
From: Frank Li <Frank.li@....com>
To: Guoniu Zhou <guoniu.zhou@....com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] media: i2c: ds90ub953: use devm_mutex_init() to
 simplify code

On Wed, Sep 10, 2025 at 05:44:40PM +0800, Guoniu Zhou wrote:
> Use devm_mutex_init() to simplify the code. No functional change.
>
> Signed-off-by: Guoniu Zhou <guoniu.zhou@....com>
> ---
>  drivers/media/i2c/ds90ub953.c | 23 +++++++++--------------
>  1 file changed, 9 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 98d6b6fab810a8f65a01a6049238cbf700eb8cd6..6f09322553640384b1f43af0dbdf4f54b4ba004a 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1339,7 +1339,9 @@ static int ub953_probe(struct i2c_client *client)
>  	if (!priv->plat_data)
>  		return dev_err_probe(dev, -ENODEV, "Platform data missing\n");
>
> -	mutex_init(&priv->reg_lock);
> +	ret = devm_mutex_init(dev, &priv->reg_lock);
> +	if (ret)
> +		return ret;
>
>  	/*
>  	 * Initialize to invalid values so that the first reg writes will
> @@ -1350,30 +1352,26 @@ static int ub953_probe(struct i2c_client *client)
>  	priv->regmap = devm_regmap_init_i2c(client, &ub953_regmap_config);
>  	if (IS_ERR(priv->regmap)) {
>  		ret = PTR_ERR(priv->regmap);
> -		dev_err_probe(dev, ret, "Failed to init regmap\n");
> -		goto err_mutex_destroy;
> +		return dev_err_probe(dev, ret, "Failed to init regmap\n");
>  	}

suppose it should be below pattern

if (IS_ERR(priv->regmap))
	return ev_err_probe(dev, PTR_ERR(priv->regmap), "Failed to init regmap\n");

Frank

>
>  	priv->clkin = devm_clk_get_optional(dev, "clkin");
>  	if (IS_ERR(priv->clkin)) {
>  		ret = PTR_ERR(priv->clkin);
> -		dev_err_probe(dev, ret, "failed to parse 'clkin'\n");
> -		goto err_mutex_destroy;
> +		return dev_err_probe(dev, ret, "failed to parse 'clkin'\n");
>  	}
>
>  	ret = ub953_parse_dt(priv);
>  	if (ret)
> -		goto err_mutex_destroy;
> +		return ret;
>
>  	ret = ub953_hw_init(priv);
>  	if (ret)
> -		goto err_mutex_destroy;
> +		return ret;
>
>  	ret = ub953_gpiochip_probe(priv);
> -	if (ret) {
> -		dev_err_probe(dev, ret, "Failed to init gpiochip\n");
> -		goto err_mutex_destroy;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to init gpiochip\n");
>
>  	ret = ub953_register_clkout(priv);
>  	if (ret) {
> @@ -1397,8 +1395,6 @@ static int ub953_probe(struct i2c_client *client)
>  	ub953_subdev_uninit(priv);
>  err_gpiochip_remove:
>  	ub953_gpiochip_remove(priv);
> -err_mutex_destroy:
> -	mutex_destroy(&priv->reg_lock);
>
>  	return ret;
>  }
> @@ -1413,7 +1409,6 @@ static void ub953_remove(struct i2c_client *client)
>  	ub953_subdev_uninit(priv);
>
>  	ub953_gpiochip_remove(priv);
> -	mutex_destroy(&priv->reg_lock);
>  }
>
>  static const struct ub953_hw_data ds90ub953_hw = {
>
> --
> 2.34.1
>