linux-kernel - Re: [PATCH v9 3/3] SPI: Add virtio SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9e9b4e5-7004-471b-a067-b6bacda2a0ca@quicinc.com>
Date: Wed, 10 Sep 2025 11:51:03 +0800
From: Haixu Cui <quic_haixcui@...cinc.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: <harald.mommer@....qualcomm.com>, <quic_msavaliy@...cinc.com>,
        <broonie@...nel.org>, <virtio-dev@...ts.linux.dev>,
        <viresh.kumar@...aro.org>, <linux-spi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hdanton@...a.com>,
        <qiang4.zhang@...ux.intel.com>, <alex.bennee@...aro.org>,
        <quic_ztu@...cinc.com>, <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v9 3/3] SPI: Add virtio SPI driver

On 9/3/2025 6:27 PM, Andy Shevchenko wrote:
> On Wed, Sep 03, 2025 at 05:04:46PM +0800, Haixu Cui wrote:
>> On 9/1/2025 8:07 PM, Andy Shevchenko wrote:
>>> On Thu, Aug 28, 2025 at 05:34:51PM +0800, Haixu Cui wrote:
>>>> This is the virtio SPI Linux kernel driver.
> 
> ...
> 
>>>> +#include <linux/completion.h>
>>>> +#include <linux/interrupt.h>
>>>> +#include <linux/io.h>
>>>> +#include <linux/module.h>
>>>> +#include <linux/spi/spi.h>
>>>> +#include <linux/stddef.h>
>>>
>>> A lot of headers are still missing. See below.
>>
>> This driver compiles successfully, and I believe all required definitions
>> are resolved through indirect inclusion. For example, since I included
>> virtio.h, there is no need to explicitly include device.h, scatterlist.h or
>> types.h.
>>
>> I avoided redundant #includes to keep the code clean and minimal.
>>
>> If there are any essential headers I’ve overlooked, please feel free to
>> highlight them—I’ll gladly include them in the next revision.
> 
> The rationale is described on https://include-what-you-use.org/.
> 

Hi Andy,

Thanks for your feedback and for pointing me to the iwyu guidelines.

I've experimented with the iwyu tool, and while for spi-virtio.c I 
noticed that it recommends header that is not directly to the code - 
such as vdso/cache.h - and occasionally suggests re-include header like 
linux/spi/spi.h that is already present.

iwyu is a power tool expecially in application-level development for C++ 
projects where header dependencies are more straightforward. However it 
seems iwyu may not yet be fully suited for analyzing Linux kernel due to 
its complexity and conditional inclusions.

Additionally, I’ve verified that the driver compiles successfully with 
both gcc and clang, which indicates that all required definitions are 
either directly or indirectly resolved.

I appreciate your guidance and will continue to refine the patch with 
clarity and maintainability in mind.

Best Regards
haixu Cui