linux-kernel - Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMC_5baavoll9pBM@google.com>
Date: Tue, 9 Sep 2025 17:01:41 -0700
From: Brian Norris <briannorris@...omium.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
	Michal Hocko <mhocko@...e.com>, Mike Rapoport <rppt@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>
Subject: Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE

On Tue, Sep 09, 2025 at 04:53:36PM -0700, Andrew Morton wrote:
> On Tue,  9 Sep 2025 13:13:57 -0700 Brian Norris <briannorris@...omium.org> wrote:
> 
> > This header uses THREAD_SIZE, which is provided by the thread_info.h
> > header but is not included in this header. Depending on the #include
> > ordering in other files, this can produce preprocessor errors.
> > 
> > ...
> >
> > --- a/include/linux/vm_event_item.h
> > +++ b/include/linux/vm_event_item.h
> > @@ -2,6 +2,8 @@
> >  #ifndef VM_EVENT_ITEM_H_INCLUDED
> >  #define VM_EVENT_ITEM_H_INCLUDED
> >  
> > +#include <linux/thread_info.h>
> > +
> >  #ifdef CONFIG_ZONE_DMA
> >  #define DMA_ZONE(xx) xx##_DMA,
> >  #else
> 
> Is there a known configuraion which triggers this, or was this from
> inspection?

The original trigger was a non-upstream driver that includes this
header. Since the root cause lay here, I figured I might as well patch
it at the origin.

Brian