linux-kernel - Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588-RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55CC0521CC5B0671+91c4b933e5c5f604ade4f7e314be6fe49efc9e99.camel@t-chip.com.cn>
Date: Wed, 10 Sep 2025 13:47:26 +0800
From: Kaison Deng <dkx@...hip.com.cn>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Jimmy Hon <honyuenkwun@...il.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Wayne Chou
 <zxf@...hip.com.cn>, Kaison Deng <dkx@...hip.com.cn>,  Quentin Schulz
 <quentin.schulz@...rry.de>, Dragan Simic <dsimic@...jaro.org>, Jonas
 Karlman <jonas@...boo.se>,  FUKAUMI Naoki <naoki@...xa.com>, Peter Robinson
 <pbrobinson@...il.com>, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Firefly
 ROC-RK3588-RT

On Tue, 2025-09-09 at 09:22 +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 09, 2025 at 09:31:47AM +0800, Kaison Deng wrote:
> > This documents Firefly ROC-RK3588-RT which is a SBC based on RK3588
> > SoC.
> > 
> > Link: https://en.t-firefly.com/product/industry/rocrk3588rt
> > 
> > Signed-off-by: Kaison Deng <dkx@...hip.com.cn>
> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index f9ee77f17ad7..6aceaa8acbb2 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -258,6 +258,11 @@ properties:
> >            - const: firefly,roc-rk3576-pc
> >            - const: rockchip,rk3576
> >  
> > +      - description: Firefly ROC-RK3588-RT
> > +        items:
> > +          - const: firefly,roc-rk3588-rt
> 
> That's just enum with ROC-RK3576-PC. BTW, all these descriptionis are
> completely redundant. Actually getting harmful, because copy+paste of
> the same is only obfuscating code.
> 
> Best regards,
> Krzysztof
> 
> 

The ROC-RK3576-PC is based on the RK3576 SoC (4*Cortex-A72 + 4*Cortex-
A53). The ROC-RK3588-RT is based on the RK3588 SoC (4*Cortex-A76 +
4*Cortex-A55). They are two different miniature single-board computers.
So it does not apply to the enum with RK3576.

Link: https://en.t-firefly.com/product/industry/rocrk3576pc

Best regards,
Kaison