linux-kernel - Re: [PATCH v11 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8d8ab9ba45946b23a4c2dcd78d20f577d12a6625.camel@codeconstruct.com.au>
Date: Wed, 10 Sep 2025 16:15:03 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: "P.K. Lee" <pkleequanta@...il.com>, robh@...nel.org, krzk+dt@...nel.org,
  conor+dt@...nel.org, joel@....id.au, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
 linux-kernel@...r.kernel.org, patrick@...cx.xyz
Cc: Jerry.Lin@...ntatw.com, Jason-Hsu@...ntatw.com, yang.chen@...ntatw.com, 
	p.k.lee@...ntatw.com
Subject: Re: [PATCH v11 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC

On Wed, 2025-09-03 at 20:06 +0800, P.K. Lee wrote:
> Add Linux device tree related to Meta (Facebook) Ventura specific
> devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to
> detect liquid leakage from all compute trays, switch trays and rack
> sensors within the rack, log the events, and take necessary actions
> accordingly.
> 
> Signed-off-by: P.K. Lee <pkleequanta@...il.com>
> ---
>  arch/arm/boot/dts/aspeed/Makefile             |    1 +
>  .../aspeed/aspeed-bmc-facebook-ventura.dts    | 1578 +++++++++++++++++
>  2 files changed, 1579 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
> 
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
> index 0f0b5b707654..476eea83445b 100644
> --- a/arch/arm/boot/dts/aspeed/Makefile
> +++ b/arch/arm/boot/dts/aspeed/Makefile
> @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-facebook-minipack.dtb \
>         aspeed-bmc-facebook-santabarbara.dtb \
>         aspeed-bmc-facebook-tiogapass.dtb \
> +       aspeed-bmc-facebook-ventura.dts \
>         aspeed-bmc-facebook-wedge40.dtb \
>         aspeed-bmc-facebook-wedge100.dtb \
>         aspeed-bmc-facebook-wedge400-data64.dtb \
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
> new file mode 100644
> index 000000000000..e00993100027
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts
> @@ -0,0 +1,1578 @@
> 

*snip*

What follows are the usual references modifying nodes from the DTSI.
Recently I've started asking that we order _these_ alphabetically, as
it makes it much easier for me to tell if they're following some
consistent order (as the unit address is not present).

I realise you've done a bunch of reordering to this point already,
please excuse this (hopefully) final request.

However, I also have some further requests below.

> +
> +&fmc {
> +       status = "okay";
> +       flash@0 {
> +               status = "okay";
> +               m25p,fast-read;
> +               label = "bmc";
> +               spi-max-frequency = <50000000>;
> +#include "openbmc-flash-layout-128.dtsi"
> +       };
> +       flash@1 {
> +               status = "okay";
> +               m25p,fast-read;
> +               label = "alt-bmc";
> +               spi-max-frequency = <50000000>;
> +       };
> +};
> +
> +&mdio0 {
> +       status = "okay";
> +};
> +
> +&mac3 {
> +       status = "okay";
> +       phy-mode = "rmii";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rmii4_default>;
> +       fixed-link {
> +               speed = <100>;
> +               full-duplex;
> +       };
> +};
> +
> +&ehci0 {
> +       status = "okay";
> +};
> +
> +&ehci1 {
> +       status = "okay";
> +};
> +
> +&uhci {
> +       status = "okay";
> +};
> +
> +&adc0 {
> +       vref-supply = <&p1v8_bmc_aux>;
> +       status = "okay";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> +               &pinctrl_adc2_default &pinctrl_adc3_default
> +               &pinctrl_adc4_default &pinctrl_adc5_default
> +               &pinctrl_adc6_default &pinctrl_adc7_default>;
> +};


*snip*

> +
> +&i2c3 {
> +       status = "okay";
> +
> +       i2c-mux@77 {
> +               compatible = "nxp,pca9548";
> +               reg = <0x77>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> 

*snip*

> +
> +               i2c3mux0ch5: i2c@5 {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       reg = <5>;
> +
> +                       pwm@20 {
> +                               compatible = "max31790";

This causes the following warning:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtb: /ahb/apb/bus@...8a000/i2c@.../i2c-mux@...i2c@...wm@20: failed to match any schema with compatible: ['max31790']

The valid compatible string is "maxim,max31790". Please update it.

*snip*

> +
> +&i2c10 {
> +       status = "okay";
> +
> 

*snip*

> +
> +       power-monitor@69 {
> +               compatible = "pmbus";

Please drop this node, it causes the following warning:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dtb: /ahb/apb/bus@...8a000/i2c@.../power-monitor@69: failed to match any schema with compatible: ['pmbus']

Cheers,

Andrew

> +               reg = <0x69>;
> +       };
> +};
> +