linux-kernel - Re: [PATCH v3 1/4] ARM: dts: aspeed: santabarbara: add sensor support for extension boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7f04c0f1bbb653de33a6a41175cd16f85778ede5.camel@codeconstruct.com.au>
Date: Wed, 10 Sep 2025 16:39:49 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Fred Chen <fredchen.openbmc@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] ARM: dts: aspeed: santabarbara: add sensor
 support for extension boards

Hi Fred,

On Mon, 2025-09-08 at 16:02 +0800, Fred Chen wrote:
> add power monitor and temperature sensors for extension boards in bus 6,
> 8, 10 and 13.
> 
> Signed-off-by: Fred Chen <fredchen.openbmc@...il.com>
> ---
>  .../aspeed-bmc-facebook-santabarbara.dts      | 824 ++++++++++++++++++
>  1 file changed, 824 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> index ee93a971c500..2f5712e9ba9f 100644

*snip*

> @@ -574,6 +606,204 @@ eeprom@52 {
>                 compatible = "atmel,24c256";
>                 reg = <0x52>;
>         };
> +
> +       i2c-mux@71 {
> +               compatible = "nxp,pca9546";
> +               reg = <0x71>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c6mux0ch0: i2c@0 {
> +                       reg = <0>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       temperature-sensor@64 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x64>;
> +                       };
> +
> +                       temperature-sensor@65 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x65>;
> +                       };
> +
> +                       temperature-sensor@67 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x67>;
> +                       };
> +
> +                       i2c-mux@72 {
> +                               compatible = "nxp,pca9546";
> +                               reg = <0x72>;
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               i2c-mux-idle-disconnect;
> +
> +                               i2c6mux1ch0: i2c@0 {
> +                                       reg = <0>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +                               };
> +                               i2c6mux1ch1: i2c@1 {
> +                                       reg = <1>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +
> +                                       voltage-sensor@48 {
> +                                               compatible = "ti,ads7830";
> +                                               reg = <0x48>;
> +                                       };
> +
> +                                       voltage-sensorr@49 {
> +                                               compatible = "ti,ads7830";
> +                                               reg = <0x49>;
> +                                       };
> +
> +                                       temperature-sensor@4a {
> +                                               compatible = "ti,tmp175";
> +                                               reg = <0x4a>;
> +                                       };
> +
> +                                       temperature-sensor@4b {
> +                                               compatible = "ti,tmp175";
> +                                               reg = <0x4b>;
> +                                       };
> +
> +                                       eeprom@56 {
> +                                               compatible = "atmel,24c256";
> +                                               reg = <0x56>;
> +                                       };
> +                               };
> +                               i2c6mux1ch2: i2c@2 {
> +                                       reg = <2>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +                               };
> +                               i2c6mux1ch3: i2c@3 {

Can you please make sure nodes consistently have empty lines between
them? Bunching them together like you have above degrades the
readability in my opinion.

Please audit the rest of the patch for the problem. Ideally audit the
rest of the devicetree too and send a follow-up patch fixing further
instances.

Andrew