linux-kernel - Re: [PATCH 6/6] uprobes/x86: Add SLS mitigation to the trampolines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250910100538.9289cc4adfa34d616bc59f39@kernel.org>
Date: Wed, 10 Sep 2025 10:05:38 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: jolsa@...nel.org, oleg@...hat.com, andrii@...nel.org,
 linux-kernel@...r.kernel.org, alx@...nel.org, eyal.birger@...il.com,
 kees@...nel.org, bpf@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 x86@...nel.org, songliubraving@...com, yhs@...com,
 john.fastabend@...il.com, haoluo@...gle.com, rostedt@...dmis.org,
 alan.maguire@...cle.com, David.Laight@...LAB.COM, thomas@...ch.de,
 mingo@...nel.org, rick.p.edgecombe@...el.com
Subject: Re: [PATCH 6/6] uprobes/x86: Add SLS mitigation to the trampolines

On Thu, 21 Aug 2025 14:28:28 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> It is trivial; no reason not to.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Looks good to me :)

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

> ---
>  arch/x86/kernel/uprobes.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/arch/x86/kernel/uprobes.c
> +++ b/arch/x86/kernel/uprobes.c
> @@ -336,6 +336,7 @@ asm (
>  	 * call ret.
>  	 */
>  	"ret\n"
> +	"int3\n"
>  	".global uretprobe_trampoline_end\n"
>  	"uretprobe_trampoline_end:\n"
>  	".popsection\n"
> @@ -891,6 +892,7 @@ asm (
>  	"pop %r11\n"
>  	"pop %rcx\n"
>  	"ret\n"
> +	"int3\n"
>  	".balign " __stringify(PAGE_SIZE) "\n"
>  	".popsection\n"
>  );
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>