linux-kernel - Re: [PATCH v2 4/6] tracing: wprobe: Add wprobe event trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250910102218.a767c63f91e7b4dcb68144ee@kernel.org>
Date: Wed, 10 Sep 2025 10:22:18 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>, Peter Zijlstra
 <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, x86@...nel.org,
 Jinchao Wang <wangjinchao600@...il.com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Thomas Gleixner <tglx@...utronix.de>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H . Peter Anvin" <hpa@...or.com>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Ian Rogers <irogers@...gle.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 4/6] tracing: wprobe: Add wprobe event trigger

On Fri,  5 Sep 2025 23:58:44 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> +static void wprobe_unregister_trigger(char *glob,
> +				      struct event_trigger_data *data,
> +				      struct trace_event_file *file)
> +{
> +	lockdep_assert_held(&event_mutex);
> +
> +	if (wprobe_trigger_exist_same(data, file)) {
> +		list_del_rcu(&data->list);
> +		trace_event_trigger_enable_disable(file, 0);
> +		update_cond_flag(file);
> +	}
> +
> +	if (data && data->ops->free)
> +		data->ops->free(data);
> +}

This function is wrongly free the passed trigger_data instead of
trigger_data on the event. The passed @data is a dummy data to
find the actual data from @file.
Thanks Jinchao to find it!

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>