linux-kernel - Re: [PATCH v2 net 0/2] selftests: drv-net: Fix issues in devlink_rate_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910083649.GI20205@horms.kernel.org>
Date: Wed, 10 Sep 2025 09:36:49 +0100
From: Simon Horman <horms@...nel.org>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Shuah Khan <shuah@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Gal Pressman <gal@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>, Nimrod Oren <noren@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net 0/2] selftests: drv-net: Fix issues in
 devlink_rate_tc_bw.py

On Tue, Sep 09, 2025 at 01:13:51PM +0300, Carolina Jubran wrote:
> This series fixes issues in devlink_rate_tc_bw.py selftest that made
> its checks unreliable and its documentation inconsistent with the
> actual configuration.
> 
> V2:
> - Dropped the patch that relaxed the total bandwidth check. Jakub
>   suggested addressing the instability with interval-based measurement
>   and by migrating to load.py. That will be handled in a follow-up.
> - Link to V1: https://lore.kernel.org/netdev/20250831080641.1828455-1-cjubran@nvidia.com/
> 
> Thanks
> 
> Carolina Jubran (2):
>   selftests: drv-net: Fix and clarify TC bandwidth split in
>     devlink_rate_tc_bw.py
>   selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py
> 
>  .../drivers/net/hw/devlink_rate_tc_bw.py      | 100 ++++++++----------
>  1 file changed, 43 insertions(+), 57 deletions(-)

Hi Carolina,

It isn't strictly related to these changes.
But CI flaggs that devlink_rate_tc_bw.py should
be present in the Makefile for in the same directory.

Given the wildcard in the Makefile I'm unsure if that
is true or not. Could you take a look?