[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <66f67ddc-93c6-4871-acdc-01623468f7d4@oss.qualcomm.com>
Date: Wed, 10 Sep 2025 10:37:49 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Bjorn Andersson <andersson@...nel.org>,
Anjelique Melendez <anjelique.melendez@....qualcomm.com>
Cc: konradybcio@...nel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink: Add support for SOCCP remoteproc
channels
On 9/9/25 5:26 PM, Bjorn Andersson wrote:
> On Tue, Sep 02, 2025 at 02:45:44PM -0700, Anjelique Melendez wrote:
>> Add support for charger FW running on SOCCP by adding the
>> "PMIC_RTR_SOCCP_APPS" channel name to the rpmsg_match list and
>> updating notify_clients logic.
>>
>> SOCCP does not have multiple PDs and hence PDR is not supported. So, if
>> the subsystem comes up/down, rpmsg driver would be probed or removed.
>> Use that for notifiying clients of pmic_glink for PDR events.
>
> Swap these two paragraphs, so that your commit message starts with a
> problem description and then you talk about the solution to the problem.
It would also make sense to briefly mention what SoCCP is.
Konrad
Powered by blists - more mailing lists