linux-kernel - Re: [PATCH net 1/3] net/mlx5e: Harden uplink netdev access against device unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250909182350.3ab98b64@kernel.org>
Date: Tue, 9 Sep 2025 18:23:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky
 <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>,
 <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Gal Pressman <gal@...dia.com>, Jianbo Liu
 <jianbol@...dia.com>
Subject: Re: [PATCH net 1/3] net/mlx5e: Harden uplink netdev access against
 device unbind

On Mon, 8 Sep 2025 13:07:04 +0300 Tariq Toukan wrote:
> +	struct net_device *netdev = mlx5_uplink_netdev_get(dev);
> +	struct mlx5e_priv *priv;
> +	int err;
> +
> +	if (!netdev)
> +		return 0;

Please don't call in variable init functions which require cleanup 
or error checking.