linux-kernel - Re: [PATCH v2 9/9] power: supply: max77976_charger: fix constant current reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910110021.7ad15002@booty>
Date: Wed, 10 Sep 2025 11:00:21 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Dzmitry Sankouski <dsankouski@...il.com>, Sebastian Reichel
 <sre@...nel.org>
Cc: Chanwoo Choi <cw00.choi@...sung.com>, Krzysztof Kozlowski
 <krzk@...nel.org>, Lee Jones <lee@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>, Sebastian Reichel
 <sebastian.reichel@...labora.com>, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 9/9] power: supply: max77976_charger: fix constant
 current reporting

Hello Dzmitry, Sebastian,

On Tue, 09 Sep 2025 21:29:19 +0300
Dzmitry Sankouski <dsankouski@...il.com> wrote:

> CHARGE_CONTROL_LIMIT is a wrong property to report charge current limit,
> because `CHARGE_*` attributes represents capacity, not current. The
> correct attribute to report and set charge current limit is
> CONSTANT_CHARGE_CURRENT.
> 
> Rename CHARGE_CONTROL_LIMIT to CONSTANT_CHARGE_CURRENT.
> 
> Fixes: 715ecbc10d6a ("power: supply: max77976: add Maxim MAX77976 charger driver")
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---
>  drivers/power/supply/max77976_charger.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/power/supply/max77976_charger.c b/drivers/power/supply/max77976_charger.c
> index e6fe68cebc32..3d6ff4005533 100644
> --- a/drivers/power/supply/max77976_charger.c
> +++ b/drivers/power/supply/max77976_charger.c
> @@ -292,10 +292,10 @@ static int max77976_get_property(struct power_supply *psy,
>  	case POWER_SUPPLY_PROP_ONLINE:
>  		err = max77976_get_online(chg, &val->intval);
>  		break;
> -	case POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX:
> +	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX:

Indeed CHARGE_CONTROL_LIMIT looks like a mistake.

Sebastian, my concern now is whether this change would be considered a
userspace ABI breakage.

Other than that, LGTM.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com