linux-kernel - Re: [PATCH] mm/slub: Removing unnecessary variable accesses in the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d5aa773-89ac-452d-999e-6a0c8ebce994@redhat.com>
Date: Wed, 10 Sep 2025 11:06:22 +0200
From: David Hildenbrand <david@...hat.com>
To: JaeJoon Jung <rgbi3307@...il.com>, Harry Yoo <harry.yoo@...cle.com>
Cc: cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
 iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
 roman.gushchin@...ux.dev, 42.hyeyoo@...il.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, rgbi3307@...er.com
Subject: Re: [PATCH] mm/slub: Removing unnecessary variable accesses in the
 get_freelist()

On 10.09.25 04:31, JaeJoon Jung wrote:
> Hi, Harry Hyeonggon Yoo,
> 
> Thank you for your kind and detailed reply.
> 
> I hadn't thought of the union data type.
> 
> Since the counters, inuse, and frozen members are unioned within the
> slab structure,
> there is the problem that the above values are not applied to
> __slab_update_freelist() and try_cmpxchg_freelist() if the existing
> code is not followed.
> 
> I canceled my patch request.
> I apologized for my inconvenience.

For the future, please

(1) Don't clean up code you don't fully understand

(2) Test your patches before submission

-- 
Cheers

David / dhildenb