linux-kernel - Re: [PATCH v2 net] net: dev_ioctl: take ops lock in hwtstamp lower paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175746780652.866782.7996733446987433045.git-patchwork-notify@kernel.org>
Date: Wed, 10 Sep 2025 01:30:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Carolina Jubran <cjubran@...dia.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, sdf@...ichev.me, kuniyu@...gle.com,
 kory.maincent@...tlin.com, kees@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, cratiu@...dia.com, dtatulea@...dia.com
Subject: Re: [PATCH v2 net] net: dev_ioctl: take ops lock in hwtstamp lower
 paths

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sun, 7 Sep 2025 11:08:21 +0300 you wrote:
> ndo hwtstamp callbacks are expected to run under the per-device ops
> lock. Make the lower get/set paths consistent with the rest of ndo
> invocations.
> 
> Kernel log:
> WARNING: CPU: 13 PID: 51364 at ./include/net/netdev_lock.h:70 __netdev_update_features+0x4bd/0xe60
> ...
> RIP: 0010:__netdev_update_features+0x4bd/0xe60
> ...
> Call Trace:
> <TASK>
> netdev_update_features+0x1f/0x60
> mlx5_hwtstamp_set+0x181/0x290 [mlx5_core]
> mlx5e_hwtstamp_set+0x19/0x30 [mlx5_core]
> dev_set_hwtstamp_phylib+0x9f/0x220
> dev_set_hwtstamp_phylib+0x9f/0x220
> dev_set_hwtstamp+0x13d/0x240
> dev_ioctl+0x12f/0x4b0
> sock_ioctl+0x171/0x370
> __x64_sys_ioctl+0x3f7/0x900
> ? __sys_setsockopt+0x69/0xb0
> do_syscall_64+0x6f/0x2e0
> entry_SYSCALL_64_after_hwframe+0x4b/0x53
> ...
> </TASK>
> ....
> 
> [...]

Here is the summary with links:
  - [v2,net] net: dev_ioctl: take ops lock in hwtstamp lower paths
    https://git.kernel.org/netdev/net/c/686cab5a18e4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html