linux-kernel - Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card compatible to match SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a884a4e-4e2a-47ce-b128-ae987bb6d3dd@kernel.org>
Date: Wed, 10 Sep 2025 11:45:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 kernel@....qualcomm.com, prasad.kumpatla@....qualcomm.com,
 ajay.nandam@....qualcomm.com
Subject: Re: [PATCH v1] arm64: dts: qcom: monaco-evk: Use correct sound card
 compatible to match SoC

On 10/09/2025 06:45, Mohammad Rafi Shaik wrote:
> The Monaco-EVK board is based on Qualcomm's QCS8300 SoC. The DTS
> previously reused the sound card compatible as "qcom,qcs8275-sndcard",
> which is based on existing coverage. To maintain clarity and consistency,
> the naming conventions for the compatible should reflect actual SoC
> rather than the board. Therefore, update the sound card compatible as
> "qcom,qcs8300-sndcard" to avoid potential confusion.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
> ---
> This patch series depends on patch series:
> https://lore.kernel.org/linux-sound/20250905142647.2566951-1-mohammad.rafi.shaik@oss.qualcomm.com/
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index f3c5d363921e..7187c1760ef5 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -38,7 +38,7 @@ max98357a: audio-codec-1 {
>  	};
>  
>  	sound {
> -		compatible = "qcom,qcs8275-sndcard";
> +		compatible = "qcom,qcs8300-sndcard";

The other patch claims that changing binding would be ABI break, so
obviously here is actual impact on users.

Also, the other patch explains that it is the same hardware, so we are
back at previous discussions (sc8380xp, sa8775p etc): we do not rename
compatibles just because your prefer something else now.

That's a NAK.

Best regards,
Krzysztof