linux-kernel - Re: [PATCH 5.10] mptcp: pm: kernel: flush: do not reset ADD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b0b81b3-aaa1-4b5f-886e-8083276b7f65@kernel.org>
Date: Wed, 10 Sep 2025 11:55:22 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: "Heyne, Maximilian" <mheyne@...zon.de>
Cc: "stable@...r.kernel.org" <stable@...r.kernel.org>,
 Thomas Dreibholz <dreibh@...ula.no>, Mat Martineau <martineau@...nel.org>,
 Jakub Kicinski <kuba@...nel.org>,
 Mat Martineau <mathew.j.martineau@...ux.intel.com>,
 Matthieu Baerts <matthieu.baerts@...sares.net>,
 "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "mptcp@...ts.01.org" <mptcp@...ts.01.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5.10] mptcp: pm: kernel: flush: do not reset ADD_ADDR
 limit

Hi Maximilian,

On 10/09/2025 11:28, Heyne, Maximilian wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
> 
> commit 68fc0f4b0d25692940cdc85c68e366cae63e1757 upstream.
> 
> A flush of the MPTCP endpoints should not affect the MPTCP limits. In
> other words, 'ip mptcp endpoint flush' should not change 'ip mptcp
> limits'.
> 
> But it was the case: the MPTCP_PM_ATTR_RCV_ADD_ADDRS (add_addr_accepted)
> limit was reset by accident. Removing the reset of this counter during a
> flush fixes this issue.
> 
> Fixes: 01cacb00b35c ("mptcp: add netlink-based PM")
> Cc: stable@...r.kernel.org
> Reported-by: Thomas Dreibholz <dreibh@...ula.no>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/579
> Reviewed-by: Mat Martineau <martineau@...nel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> Link: https://patch.msgid.link/20250815-net-mptcp-misc-fixes-6-17-rc2-v1-2-521fe9957892@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> [adjusted patch by removing WRITE_ONCE to take into account the missing
>  commit 72603d207d59 ("mptcp: use WRITE_ONCE for the pernet *_max")]
> Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
> ---
> For some reason only the corresponding selftest patch was backported and
> it's now failing on 5.10 kernels. I tested that with this patch the
> selftest is succeeding again.

Thank you for this backport. It looks good to me!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

I was waiting for the FAILED notification for this patch before adapting
it for v5.10, but it looks like I never got it, see:

https://lore.kernel.org/017c0cd3-7391-4d53-9e3e-ebdea5fa26da@kernel.org

No problem, that was not critical, and we now have a fix :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.