linux-kernel - Re: [PATCH] acpi,srat: Fix incorrect device handle check for Generic Initiator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910105729.000070a5@huawei.com>
Date: Wed, 10 Sep 2025 10:57:29 +0100
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Shuai Xue <xueshuai@...ux.alibaba.com>
CC: <rafael@...nel.org>, <lenb@...nel.org>, <robert.moore@...el.com>,
	<andrew@...nel.org>, <bfaccini@...dia.com>, <eahariha@...ux.microsoft.com>,
	<dan.j.williams@...el.com>, <thorsten.blum@...ux.dev>, <gourry@...rry.net>,
	<nunodasneves@...ux.microsoft.com>, <wangyuquan1236@...tium.com.cn>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<acpica-devel@...ts.linux.dev>
Subject: Re: [PATCH] acpi,srat: Fix incorrect device handle check for
 Generic Initiator

On Wed, 10 Sep 2025 17:39:49 +0800
Shuai Xue <xueshuai@...ux.alibaba.com> wrote:

> The Generic Initiator Affinity Structure in SRAT table uses device
> handle type field to indicate the device type. According to ACPI
> specification, the device handle type value of 1 represents PCI device,
> not 0.
> 
> Fix this by defining explicit macros for device handle types and using
> the correct check for PCI devices:
> 
> - ACPI_SRAT_ACPI_DEVICE_HANDLE (0): ACPI device handle
> - ACPI_SRAT_PCI_DEVICE_HANDLE (1): PCI device handle
> 
> Fixes: 894c26a1c274 ("ACPI: Support Generic Initiator only domains")
> Reported-by: Wu Zongyong <wuzongyong@...ux.alibaba.com>
> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>

The actbl3.h additions need to go through acpcia and then have a link
tag in here to show that it was merged.  Perhaps just fix it with a number
for now and follow up with the acpcia stuff in the longer run?

Also note clearly this only affects a debug print - no functional bug.
That may change whether people choose to backport this or not.

I'm curious on whether you are thinking of wiring this up so that
we can set the appropriate nodes on PCI Devices other than by doing it
with _PXM().  For obscure reasons there can be references both ways
(so DSDT Device entry -> SRAT via _PXM, and SRAT -> Device via this field
of generic initiators).

For now we only implement the first one so all we need is a node to be
instantiated for the GI to sit in.

Come to think of it the fix that made PCI device entries in DSDT with _PXM
turn up in the right place was reverted (for a problem with broken firmware
on AMD threadripper systems - IIRC that I think is long solved).
Not sure if that path even works today and the one this code is about has
never been hooked up.

Thanks for the fix!

Jonathan


> ---
>  drivers/acpi/numa/srat.c | 2 +-
>  include/acpi/actbl3.h    | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 53816dfab645..de71b370a275 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -237,7 +237,7 @@ acpi_table_print_srat_entry(struct acpi_subtable_header *header)
>  		struct acpi_srat_generic_affinity *p =
>  			(struct acpi_srat_generic_affinity *)header;
>  
> -		if (p->device_handle_type == 0) {
> +		if (p->device_handle_type == ACPI_SRAT_PCI_DEVICE_HANDLE) {
>  			/*
>  			 * For pci devices this may be the only place they
>  			 * are assigned a proximity domain
> diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
> index 79d3aa5a4bad..c8488614429c 100644
> --- a/include/acpi/actbl3.h
> +++ b/include/acpi/actbl3.h
> @@ -284,6 +284,9 @@ struct acpi_srat_gic_its_affinity {
>   * 6: ACPI_SRAT_TYPE_GENERIC_PORT_AFFINITY
>   */
>  
> +#define ACPI_SRAT_APCI_DEVICE_HANDLE	(0)
> +#define ACPI_SRAT_PCI_DEVICE_HANDLE	(1)
> +
>  #define ACPI_SRAT_DEVICE_HANDLE_SIZE	16
>  
>  struct acpi_srat_generic_affinity {