linux-kernel - Re: [PATCH 2/2] rust: pin-init: add pin projections to `#[pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLgi5M+9gaH8QmwLd=7Gto7C6nceLd6g25a4O7hcrax16kQ@mail.gmail.com>
Date: Wed, 10 Sep 2025 12:24:12 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Benno Lossin <lossin@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Tejun Heo <tj@...nel.org>, Tamir Duberstein <tamird@...il.com>, 
	Dirk Behme <dirk.behme@...il.com>, Alban Kurti <kurti@...icto.ai>, Fiona Behrens <me@...enk.dev>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rust: pin-init: add pin projections to `#[pin_data]`

On Wed, Sep 10, 2025 at 12:23 PM Alice Ryhl <aliceryhl@...gle.com> wrote:
>
> On Fri, Sep 5, 2025 at 7:12 PM Benno Lossin <lossin@...nel.org> wrote:
> >
> > Make the `#[pin_data]` macro generate a `*Projection` struct that holds
> > either `Pin<&mut Field>` or `&mut Field` for every field of the original
> > struct. Which version is chosen depends on weather there is a `#[pin]`
> > or not respectively. Access to this projected version is enabled through
> > generating `fn project(self: Pin<&mut Self>) -> SelfProjection<'_>`.
> >
> > Link: https://github.com/Rust-for-Linux/pin-init/pull/75/commits/2d698367d646c7ede90e01aa22842c1002d017b3
> > [ Adapt workqueue to use the new projection instead of its own, custom
> >   one - Benno ]
> > Signed-off-by: Benno Lossin <lossin@...nel.org>
> > ---
> >  rust/kernel/workqueue.rs    | 10 ++-----
> >  rust/pin-init/src/macros.rs | 60 +++++++++++++++++++++++++++++++++++++
> >  2 files changed, 62 insertions(+), 8 deletions(-)
> >
> > diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs
> > index b9343d5bc00f..6ca14c629643 100644
> > --- a/rust/kernel/workqueue.rs
> > +++ b/rust/kernel/workqueue.rs
> > @@ -356,18 +356,12 @@ struct ClosureWork<T> {
> >      func: Option<T>,
> >  }
> >
> > -impl<T> ClosureWork<T> {
> > -    fn project(self: Pin<&mut Self>) -> &mut Option<T> {
> > -        // SAFETY: The `func` field is not structurally pinned.
> > -        unsafe { &mut self.get_unchecked_mut().func }
> > -    }
> > -}
> > -
> >  impl<T: FnOnce()> WorkItem for ClosureWork<T> {
> >      type Pointer = Pin<KBox<Self>>;
> >
> >      fn run(mut this: Pin<KBox<Self>>) {
> > -        if let Some(func) = this.as_mut().project().take() {
> > +        if let Some(func) = this.as_mut().project().func.take() {
> > +            // if let Some(func) = this.as_mut().project_func().take() {

Spurious comment.