linux-kernel - Re: [PATCH net v2] mptcp: sockopt: make sync_socket_options propagate SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175746901150.871782.13982454785645572183.git-patchwork-notify@kernel.org>
Date: Wed, 10 Sep 2025 01:50:11 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Krister Johansen <kjlx@...pleofstupid.com>
Cc: matttbe@...nel.org, martineau@...nel.org, geliang@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, fw@...len.de, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org, me@...idreaver.com
Subject: Re: [PATCH net v2] mptcp: sockopt: make sync_socket_options propagate
 SOCK_KEEPOPEN

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 8 Sep 2025 11:16:01 -0700 you wrote:
> Users reported a scenario where MPTCP connections that were configured
> with SO_KEEPALIVE prior to connect would fail to enable their keepalives
> if MTPCP fell back to TCP mode.
> 
> After investigating, this affects keepalives for any connection where
> sync_socket_options is called on a socket that is in the closed or
> listening state.  Joins are handled properly. For connects,
> sync_socket_options is called when the socket is still in the closed
> state.  The tcp_set_keepalive() function does not act on sockets that
> are closed or listening, hence keepalive is not immediately enabled.
> Since the SO_KEEPOPEN flag is absent, it is not enabled later in the
> connect sequence via tcp_finish_connect.  Setting the keepalive via
> sockopt after connect does work, but would not address any subsequently
> created flows.
> 
> [...]

Here is the summary with links:
  - [net,v2] mptcp: sockopt: make sync_socket_options propagate SOCK_KEEPOPEN
    https://git.kernel.org/netdev/net/c/648de37416b3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html