linux-kernel - Re: [PATCH v14 06/22] KVM: x86: Load guest FPU state when access XSAVE-managed MSRs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMFedyAqac+S38P2@intel.com>
Date: Wed, 10 Sep 2025 19:18:15 +0800
From: Chao Gao <chao.gao@...el.com>
To: Xiaoyao Li <xiaoyao.li@...el.com>
CC: <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <acme@...hat.com>,
	<bp@...en8.de>, <dave.hansen@...ux.intel.com>, <hpa@...or.com>,
	<john.allen@....com>, <mingo@...nel.org>, <mingo@...hat.com>,
	<minipli@...ecurity.net>, <mlevitsk@...hat.com>, <namhyung@...nel.org>,
	<pbonzini@...hat.com>, <prsampat@....com>, <rick.p.edgecombe@...el.com>,
	<seanjc@...gle.com>, <shuah@...nel.org>, <tglx@...utronix.de>,
	<weijiang.yang@...el.com>, <x86@...nel.org>, <xin@...or.com>
Subject: Re: [PATCH v14 06/22] KVM: x86: Load guest FPU state when access
 XSAVE-managed MSRs

On Wed, Sep 10, 2025 at 05:37:50PM +0800, Xiaoyao Li wrote:
>On 9/9/2025 5:39 PM, Chao Gao wrote:
>> From: Sean Christopherson <seanjc@...gle.com>
>> 
>> Load the guest's FPU state if userspace is accessing MSRs whose values
>> are managed by XSAVES. Introduce two helpers, kvm_{get,set}_xstate_msr(),
>> to facilitate access to such kind of MSRs.
>> 
>> If MSRs supported in kvm_caps.supported_xss are passed through to guest,
>> the guest MSRs are swapped with host's before vCPU exits to userspace and
>> after it reenters kernel before next VM-entry.
>> 
>> Because the modified code is also used for the KVM_GET_MSRS device ioctl(),
>> explicitly check @vcpu is non-null before attempting to load guest state.
>> The XSAVE-managed MSRs cannot be retrieved via the device ioctl() without
>> loading guest FPU state (which doesn't exist).
>> 
>> Note that guest_cpuid_has() is not queried as host userspace is allowed to
>> access MSRs that have not been exposed to the guest, e.g. it might do
>> KVM_SET_MSRS prior to KVM_SET_CPUID2.

...

>> +	bool fpu_loaded = false;
>>   	int i;
>> -	for (i = 0; i < msrs->nmsrs; ++i)
>> +	for (i = 0; i < msrs->nmsrs; ++i) {
>> +		/*
>> +		 * If userspace is accessing one or more XSTATE-managed MSRs,
>> +		 * temporarily load the guest's FPU state so that the guest's
>> +		 * MSR value(s) is resident in hardware, i.e. so that KVM can
>> +		 * get/set the MSR via RDMSR/WRMSR.
>> +		 */
>> +		if (vcpu && !fpu_loaded && kvm_caps.supported_xss &&
>
>why not check vcpu->arch.guest_supported_xss?

Looks like Sean anticipated someone would ask this question.