linux-kernel - Re: [PATCH v2 2/3] dt-bindings: display: sitronix,st7920: Add DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910-ant-of-angelic-vastness-b5caa5@kuoka>
Date: Wed, 10 Sep 2025 13:35:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Iker Pedrosa <ikerpedrosam@...il.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Javier Martinez Canillas <javierm@...hat.com>, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: display: sitronix,st7920: Add DT
 schema

On Tue, Sep 09, 2025 at 06:52:44PM +0200, Iker Pedrosa wrote:
> Add binding for Sitronix ST7920 display.
> 
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>
> ---
>  .../bindings/display/sitronix,st7920.yaml          | 52 ++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 

Please organize the patch documenting compatible (DT bindings) before their user.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

...

> +  reg:
> +    description: The chip-select number for the device on the SPI bus.

Drop description, obvious/redundant.

> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 600000
> +

I don't see how my comment about supply was addressed. You never
responded, nothing explained in the changelog, nothing explained in the
commit msg.

> +required:
> +  - compatible
> +  - reg
> +  - spi-max-frequency
> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    // Example: ST7920 connected to an SPI bus

Drop comment.

> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        display@0 {
> +            compatible = "sitronix,st7920";
> +            reg = <0>;
> +            spi-max-frequency = <600000>;
> +            spi-cs-high;
> +        };
> +    };
> 
> -- 
> 2.51.0
>