linux-kernel - Re: [PATCH 1/2] cpuidle: qcom-spm: fix device and OF node leaks at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gXY-QRFonw1fU7ok5k0ieNXo99gmQhXTbXQ8icDwEhCg@mail.gmail.com>
Date: Wed, 10 Sep 2025 13:36:15 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Johan Hovold <johan@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, linux-arm-msm@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cpuidle: qcom-spm: fix device and OF node leaks at probe

On Mon, Sep 8, 2025 at 5:40 PM Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 9/8/25 5:22 PM, Johan Hovold wrote:
> > Make sure to drop the reference to the saw device taken by
> > of_find_device_by_node() after retrieving its driver data during
> > probe().
> >
> > Also drop the reference to the CPU node sooner to avoid leaking it in
> > case there is no saw node or device.
> >
> > Fixes: 60f3692b5f0b ("cpuidle: qcom_spm: Detach state machine from main SPM handling")
> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Applied as 6.18 material along with the [2/2], thanks!