linux-kernel - Re: [PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property ti,gpio-data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e526e93e-1373-4f1e-82ab-6b22d68211cd@mleia.com>
Date: Wed, 10 Sep 2025 15:06:12 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Guoniu Zhou <guoniu.zhou@....com>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Frank Li <Frank.Li@....com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: media: ti,ds90ub953: Add new property
 ti,gpio-data

On 9/10/25 12:44, Guoniu Zhou wrote:
> Add new property ti,gpio-data to let user select ds90ub953 gpio output
> remote data coming from the compatible deserializer.
> 
> Signed-off-by: Guoniu Zhou <guoniu.zhou@....com>
> ---
>   Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..7c3144677f11004468ed3a3fba74e6eee2d259d2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> @@ -26,6 +26,16 @@ properties:
>   
>     gpio-controller: true
>   
> +  ti,gpio-data:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    default: 0
> +    minimum: 0
> +    maximum: 15
> +    description: |
> +      Program each gpio pin to output remote data coming from compatible
> +      deserializer using the LOCAL_GPIO_DATA[7:4] register. This property
> +      has to be a '/bits/ 8' value.
> +

No, this shall be done as a GPIO controller function of the IC, and not
as a hardcoded (!) custom property.

>     clocks:
>       maxItems: 1
>       description:
> 

NAK, the approach is wrong.

-- 
Best wishes,
Vladimir