linux-kernel - Re: [PATCH v2 09/10] asm-generic: percpu: Add assembly guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecb230a3384e22acf4fa6c03466c7db7092ad9f5.camel@sipsolutions.net>
Date: Wed, 10 Sep 2025 14:12:16 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Tiwei Bie <tiwei.bie@...ux.dev>, richard@....at, 
	anton.ivanov@...bridgegreys.com
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	benjamin@...solutions.net, arnd@...db.de, tiwei.btw@...group.com, 
	linux-arch@...r.kernel.org
Subject: Re: [PATCH v2 09/10] asm-generic: percpu: Add assembly guard

On Sun, 2025-08-10 at 13:51 +0800, Tiwei Bie wrote:
> From: Tiwei Bie <tiwei.btw@...group.com>
> 
> Currently, asm/percpu.h is directly or indirectly included by
> some assembly files on x86. Some of them (e.g., checksum_32.S)
> are also used on um. But x86 and um provide different versions
> of asm/percpu.h -- um uses asm-generic/percpu.h directly.
> 
> When SMP is enabled, asm-generic/percpu.h will introduce C code
> that cannot be assembled. Since asm-generic/percpu.h currently
> is not designed for use in assembly, and these assembly files
> do not actually need asm/percpu.h on um, let's add the assembly
> guard in asm-generic/percpu.h to fix this issue.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: linux-arch@...r.kernel.org

Can we get an ACK from someone for this? :) Or a reject and we need to
find other ways of doing things?

johannes