linux-kernel - Re: [PATCH v2 2/2] iio: adc: Add the NXP SAR ADC support for the s32g2/3 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c746e72c-dbd9-4afb-9da4-5d13733fd561@baylibre.com>
Date: Thu, 11 Sep 2025 08:26:06 -0500
From: David Lechner <dlechner@...libre.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Jonathan Cameron <jic23@...nel.org>
Cc: nuno.sa@...log.com, andy@...nel.org, robh@...nel.org,
 conor+dt@...nel.org, krzk+dt@...nel.org, linux-iio@...r.kernel.org,
 s32@....com, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 chester62515@...il.com, mbrugger@...e.com, ghennadi.procopciuc@....nxp.com
Subject: Re: [PATCH v2 2/2] iio: adc: Add the NXP SAR ADC support for the
 s32g2/3 platforms

On 9/11/25 7:55 AM, Daniel Lezcano wrote:
> 
> Hi Jonathan,
> 
> thanks for the review
> 
> On 10/09/2025 19:32, Jonathan Cameron wrote:
>> On Wed, 10 Sep 2025 17:57:56 +0200
>> Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
> 
> [ ... ]
> 

...

> 
>>> +    indio_dev->name = dev_name(dev);
>>
>> This should be the 'part number'.  That is a little ill defined
>> for a SoC integrated ADC, but generally not what we get from dev_name()
>> on the platform_device.
> 
> Sorry, I don't get the comment. If I refer to the different drivers there is not consistency with the iio_dev->name.

dev_name() will be something like adc@...45678 from the devicetree,
so not the "part number".

> 
> rtq6056.c:      indio_dev->name = "rtq6056";

This style is preferred if there is only one supported part.

> rzg2l_adc.c:    indio_dev->name = DRIVER_NAME;

We try to avoid using a macro for the driver name like this.

> sc27xx_adc.c:   indio_dev->name = dev_name(dev);

Looks like we missed catching this one in review.

> mt6359-auxadc.c:  indio_dev->name = adc_dev->chip_info->model_name;

This is preferred if there is more than one part supported in the driver.

> mcp3911.c:      indio_dev->name = spi_get_device_id(spi)->name;

This is fine too in cases where there isn't chip_info.

> 
> Are you suggesting to use the compatible part number ?
> 
>     indio->name = "s32g2-sar-adc";
> 

That works.