linux-kernel - Re: [PATCH] arm64: dts: renesas: r9a09g047: enable tx coe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVU6=sLCgAe6pGjdt8wpq6yvx7e1bEYPO5TPQwnHyziVw@mail.gmail.com>
Date: Thu, 11 Sep 2025 16:16:03 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: magnus.damm@...il.com, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-renesas-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	biju.das.jz@...renesas.com, john.madieu@...il.com
Subject: Re: [PATCH] arm64: dts: renesas: r9a09g047: enable tx coe support

Hi John,

Thanks for your patch!

On Thu, 14 Aug 2025 at 17:35, John Madieu <john.madieu.xa@...renesas.com> wrote:
> The GBETH IPs found on RZ/G3E SoC family are compatible with the stmmac driver.
> They have a MAC HW feature register used by this driver to enable respective
> features. While the register advertises Tx coe support, it was not enabled by
> the driver due to the 'snps,force_thresh_dma_mode' dtsi property.
>
> Switch from 'snps,force_thresh_dma_mode' to 'snps,force_sf_dma_mode' to enable
> Tx checksum offload support on both GBETH IPs. While at it, also switch from
> 'snps,fixed-busrt' to 'nsps,mixed-burst' and remove 'snps,no-pbl-x8' for

burst ... snps

> optimal DMA configuration. This improvement results in a measurable TCP Tx
> performance gains, increasing throughput by 20Mbps.
>
> Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>

LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v6.18, with the typos fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds