linux-kernel - Re: [PATCH net-next 2/2] net: xilinx: axienet: Add inline comment for stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dc424bf-c19b-4eeb-82db-88bff4f85d46@linux.dev>
Date: Thu, 11 Sep 2025 10:35:22 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Suraj Gupta <suraj.gupta2@....com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, michal.simek@....com, radhey.shyam.pandey@....com,
 horms@...nel.org
Cc: netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, harini.katakam@....com
Subject: Re: [PATCH net-next 2/2] net: xilinx: axienet: Add inline comment for
 stats_lock mutex definition

On 9/11/25 03:28, Suraj Gupta wrote:
> Add inline comment to document the purpose of the stats_lock mutex in
> the axienet_local structure. This mutex protects the hw_stats_seqcount
> sequence counter used for hardware statistics synchronization.
> 
> Fixes checkpatch warning:
> CHECK: struct mutex definition without comment
> 
> Signed-off-by: Suraj Gupta <suraj.gupta2@....com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h
> index 5ff742103beb..99b9c27bbd60 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet.h
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h
> @@ -598,7 +598,7 @@ struct axienet_local {
>  
>  	u64 hw_stat_base[STAT_COUNT];
>  	u32 hw_last_counter[STAT_COUNT];
> -	seqcount_mutex_t hw_stats_seqcount;
> +	seqcount_mutex_t hw_stats_seqcount; /* Lock for hardware statistics */
>  	struct mutex stats_lock;
>  	struct delayed_work stats_work;
>  	bool reset_in_progress;

NAK. This is already documented in the kernel-doc comment.