[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250911150850.GAaMLmAoi5fTIznQzY@fat_crate.local>
Date: Thu, 11 Sep 2025 17:08:50 +0200
From: Borislav Petkov <bp@...en8.de>
To: Babu Moger <babu.moger@....com>
Cc: corbet@....net, tony.luck@...el.com, reinette.chatre@...el.com,
Dave.Martin@....com, james.morse@....com, tglx@...utronix.de,
mingo@...hat.com, dave.hansen@...ux.intel.com, x86@...nel.org,
hpa@...or.com, kas@...nel.org, rick.p.edgecombe@...el.com,
akpm@...ux-foundation.org, paulmck@...nel.org, frederic@...nel.org,
pmladek@...e.com, rostedt@...dmis.org, kees@...nel.org,
arnd@...db.de, fvdl@...gle.com, seanjc@...gle.com,
thomas.lendacky@....com, pawan.kumar.gupta@...ux.intel.com,
perry.yuan@....com, manali.shukla@....com, sohil.mehta@...el.com,
xin@...or.com, Neeraj.Upadhyay@....com, peterz@...radead.org,
tiala@...rosoft.com, mario.limonciello@....com,
dapeng1.mi@...ux.intel.com, michael.roth@....com,
chang.seok.bae@...el.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev,
kvm@...r.kernel.org, peternewman@...gle.com, eranian@...gle.com,
gautham.shenoy@....com
Subject: Re: [PATCH v18 26/33] fs/resctrl: Introduce mbm_assign_on_mkdir to
enable assignments on mkdir
On Fri, Sep 05, 2025 at 04:34:25PM -0500, Babu Moger wrote:
> The "mbm_event" counter assignment mode allows users to assign a hardware
> counter to an RMID, event pair and monitor the bandwidth as long as it is
> assigned.
>
> Introduce a user-configurable option that determines if a counter will
> automatically be assigned to an RMID, event pair when its associated
> monitor group is created via mkdir. Accessible when "mbm_event" counter
> assignment mode is enabled.
This is just a note for the future - you don't have to go change things now:
reading those commit messages back-to-back, there's a lot of boilerplate code
which repeats with each commit message and there's a lot of text talking what
the patch does.
Please tone this down in the future - it is really annoying and doesn't bring
a whole lot by repeating things or explaining the obvious. Just concentrate on
explaining why the patch exists and mention any non-obvious things.
Everything else people can find by searching the net.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists