linux-kernel - Re: [PATCH] mmc: dw_mmc-rockchip: add dependency to ROCKCHIP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1813054.X513TT2pbd@diego>
Date: Thu, 11 Sep 2025 18:05:59 +0200
From: Heiko Stübner <heiko@...ech.de>
To: arnd@...db.de, Mikko Rapeli <mikko.rapeli@...aro.org>,
 Ulf Hansson <ulf.hansson@...aro.org>
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
 adrian.hunter@...el.com, victor.shih@...esyslogic.com.tw,
 ben.chuang@...esyslogic.com.tw, geert+renesas@...der.be,
 angelogioacchino.delregno@...labora.com, dlan@...too.org,
 zhoubinbin@...ngson.cn
Subject:
 Re: [PATCH] mmc: dw_mmc-rockchip: add dependency to ROCKCHIP_PM_DOMAINS

Hi,

Am Donnerstag, 11. September 2025, 17:03:14 Mitteleuropäische Sommerzeit schrieb Ulf Hansson:
> On Thu, 11 Sept 2025 at 16:43, Mikko Rapeli <mikko.rapeli@...aro.org> wrote:
> > @@ -866,7 +866,7 @@ config MMC_DW_PCI
> >
> >  config MMC_DW_ROCKCHIP
> >         tristate "Rockchip specific extensions for Synopsys DW Memory Card Interface"
> > -       depends on MMC_DW && ARCH_ROCKCHIP
> > +       depends on MMC_DW && ARCH_ROCKCHIP && ROCKCHIP_PM_DOMAINS
> 
> Rather than "depends on", I think a "select" is better to be added
> from the platform's Kconfig. Probably drivers/soc/rockchip/Kconfig is
> where to put this.
> 
> Assuming that ROCKCHIP_PM_DOMAINS is a critical piece for most
> Rockchip platforms to work.

I'd think
- arch/arm64/Kconfig.platforms
- arch/arm/mach-rockchip/Kconfig
would be the correct positions.

And as Ulf suggested, this should be a "select"


And I guess, always selecting it makes sense as well.

Every supported soc back to the before 2012 RK3066 has controllable
power-domains and while the driver is selected in both the arm32+64
defconfigs, this still allows people to manually de-select the driver
leaving most elements to defer.

So yes, always-selecting the driver makes a lot of sense.


Thanks
Heiko