| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250911-max77705_77976_charger_improvement-v3-8-35203686fa29@gmail.com>
Date: Thu, 11 Sep 2025 20:57:16 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Chanwoo Choi <cw00.choi@...sung.com>,
Krzysztof Kozlowski <krzk@...nel.org>, Lee Jones <lee@...nel.org>,
Sebastian Reichel <sre@...nel.org>,
Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Sebastian Reichel <sebastian.reichel@...labora.com>,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
Dzmitry Sankouski <dsankouski@...il.com>
Subject: [PATCH v3 8/9] power: supply: max77705_charger: implement aicl
feature
Adaptive input current allows charger to reduce it's current
consumption, when source is not able to provide enough power.
Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
---
drivers/power/supply/max77705_charger.c | 70 +++++++++++++++++++++++++++++++++
include/linux/power/max77705_charger.h | 5 +++
2 files changed, 75 insertions(+)
diff --git a/drivers/power/supply/max77705_charger.c b/drivers/power/supply/max77705_charger.c
index 940cf3bf6d1a..a943efc67546 100644
--- a/drivers/power/supply/max77705_charger.c
+++ b/drivers/power/supply/max77705_charger.c
@@ -40,6 +40,16 @@ static enum power_supply_property max77705_charger_props[] = {
POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT,
};
+static irqreturn_t max77705_aicl_irq(int irq, void *irq_drv_data)
+{
+ struct max77705_charger_data *chg = irq_drv_data;
+
+ queue_delayed_work(chg->wqueue, &chg->aicl_work,
+ msecs_to_jiffies(AICL_WORK_DELAY));
+
+ return IRQ_HANDLED;
+}
+
static irqreturn_t max77705_chgin_irq(int irq, void *irq_drv_data)
{
struct max77705_charger_data *chg = irq_drv_data;
@@ -445,6 +455,40 @@ static const struct power_supply_desc max77705_charger_psy_desc = {
.set_property = max77705_set_property,
};
+static void max77705_aicl_isr_work(struct work_struct *work)
+{
+ unsigned int regval, irq_status;
+ int err;
+ struct max77705_charger_data *chg =
+ container_of(work, struct max77705_charger_data, aicl_work.work);
+
+ regmap_read(chg->regmap, MAX77705_CHG_REG_INT_OK, &irq_status);
+ if (!chg->is_aicl_irq_disabled) {
+ disable_irq(chg->aicl_irq);
+ chg->is_aicl_irq_disabled = true;
+ }
+
+ if (!(irq_status & BIT(MAX77705_AICL_I))) {
+ err = regmap_field_read(chg->rfield[MAX77705_CHG_CHGIN_LIM], ®val);
+ if (err < 0)
+ return;
+
+ regval--;
+
+ pr_info("aicl call. regval: %d\n", regval);
+ err = regmap_field_write(chg->rfield[MAX77705_CHG_CHGIN_LIM], regval);
+ if (err < 0)
+ return;
+
+ queue_delayed_work(chg->wqueue, &chg->aicl_work,
+ msecs_to_jiffies(AICL_WORK_DELAY));
+ } else {
+ pr_info("aicl finish\n");
+ enable_irq(chg->aicl_irq);
+ chg->is_aicl_irq_disabled = false;
+ }
+}
+
static void max77705_chgin_isr_work(struct work_struct *work)
{
struct max77705_charger_data *chg =
@@ -607,6 +651,16 @@ static int max77705_charger_probe(struct i2c_client *i2c)
if (ret)
return dev_err_probe(dev, ret, "failed to add irq chip\n");
+ ret = devm_request_threaded_irq(dev, regmap_irq_get_virq(irq_data, MAX77705_CHGIN_I),
+ NULL, max77705_chgin_irq,
+ IRQF_TRIGGER_HIGH,
+ "chgin-irq", chg);
+ if (ret) {
+ pr_err("%s: Failed to Request IRQ (%d)\n", __func__, ret);
+ return ret;
+ }
+
+
chg->wqueue = create_singlethread_workqueue(dev_name(dev));
if (!chg->wqueue)
return dev_err_probe(dev, -ENOMEM, "failed to create workqueue\n");
@@ -617,6 +671,12 @@ static int max77705_charger_probe(struct i2c_client *i2c)
goto destroy_wq;
}
+ ret = devm_delayed_work_autocancel(dev, &chg->aicl_work, max77705_aicl_isr_work);
+ if (ret) {
+ dev_err_probe(dev, ret, "failed to initialize interrupt work\n");
+ goto destroy_wq;
+ }
+
ret = max77705_charger_initialize(chg);
if (ret) {
dev_err_probe(dev, ret, "failed to initialize charger IC\n");
@@ -632,6 +692,16 @@ static int max77705_charger_probe(struct i2c_client *i2c)
goto destroy_wq;
}
+ chg->aicl_irq = regmap_irq_get_virq(irq_data, MAX77705_AICL_I);
+ ret = devm_request_threaded_irq(dev, chg->aicl_irq,
+ NULL, max77705_aicl_irq,
+ IRQF_TRIGGER_HIGH,
+ "aicl-irq", chg);
+ if (ret) {
+ pr_err("%s: Failed to Request IRQ (%d)\n", __func__, ret);
+ goto destroy_wq;
+ }
+
ret = max77705_charger_enable(chg);
if (ret) {
dev_err_probe(dev, ret, "failed to enable charge\n");
diff --git a/include/linux/power/max77705_charger.h b/include/linux/power/max77705_charger.h
index 6653abfdf747..92fef95e4ac4 100644
--- a/include/linux/power/max77705_charger.h
+++ b/include/linux/power/max77705_charger.h
@@ -123,6 +123,8 @@
#define MAX77705_DISABLE_SKIP 1
#define MAX77705_AUTO_SKIP 0
+#define AICL_WORK_DELAY 100
+
/* uA */
#define MAX77705_CURRENT_CHGIN_STEP 25000
#define MAX77705_CURRENT_CHG_STEP 50000
@@ -185,7 +187,10 @@ struct max77705_charger_data {
struct power_supply_battery_info *bat_info;
struct workqueue_struct *wqueue;
struct work_struct chgin_work;
+ struct delayed_work aicl_work;
struct power_supply *psy_chg;
+ int is_aicl_irq_disabled;
+ int aicl_irq;
};
#endif /* __MAX77705_CHARGER_H */
--
2.39.5
Powered by blists - more mailing lists