linux-kernel - Re: [PATCH V1] accel/amdxdna: Fix an integer overflow in aie2_query_ctx_status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3545d96-c463-f4b9-6b4b-7a8360cf9e2c@amd.com>
Date: Thu, 11 Sep 2025 11:34:58 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: "Falkowski, Maciej" <maciej.falkowski@...ux.intel.com>,
	<ogabbay@...nel.org>, <quic_jhugo@...cinc.com>,
	<jacek.lawrynowicz@...ux.intel.com>, <dri-devel@...ts.freedesktop.org>,
	<dan.carpenter@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <max.zhen@....com>,
	<sonal.santan@....com>, <mario.limonciello@....com>
Subject: Re: [PATCH V1] accel/amdxdna: Fix an integer overflow in
 aie2_query_ctx_status_array()

Applied to drm-misc-next

On 9/11/25 07:56, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@...ux.intel.com>
>
> On 9/9/2025 5:45 PM, Lizhi Hou wrote:
>> The unpublished smatch static checker reported a warning.
>>
>> drivers/accel/amdxdna/aie2_pci.c:904 aie2_query_ctx_status_array()
>> warn: potential user controlled sizeof overflow
>> 'args->num_element * args->element_size' '1-u32max(user) * 
>> 1-u32max(user)'
>>
>> Even this will not cause a real issue, it is better to put a reasonable
>> limitation for element_size and num_element. Add condition to make sure
>> the input element_size <= 4K and num_element <= 1K.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> Closes: 
>> https://lore.kernel.org/dri-devel/aL56ZCLyl3tLQM1e@stanley.mountain/
>> Fixes: 2f509fe6a42c ("accel/amdxdna: Add ioctl 
>> DRM_IOCTL_AMDXDNA_GET_ARRAY")
>> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
>> ---
>>   drivers/accel/amdxdna/aie2_pci.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_pci.c 
>> b/drivers/accel/amdxdna/aie2_pci.c
>> index 87c425e3d2b9..6e39c769bb6d 100644
>> --- a/drivers/accel/amdxdna/aie2_pci.c
>> +++ b/drivers/accel/amdxdna/aie2_pci.c
>> @@ -898,6 +898,12 @@ static int aie2_query_ctx_status_array(struct 
>> amdxdna_client *client,
>>         drm_WARN_ON(&xdna->ddev, !mutex_is_locked(&xdna->dev_lock));
>>   +    if (args->element_size > SZ_4K || args->num_element > SZ_1K) {
>> +        XDNA_DBG(xdna, "Invalid element size %d or number of element 
>> %d",
>> +             args->element_size, args->num_element);
>> +        return -EINVAL;
>> +    }
>> +
>>       array_args.element_size = min(args->element_size,
>>                         sizeof(struct amdxdna_drm_hwctx_entry));
>>       array_args.buffer = args->buffer;