linux-kernel - Re: [PATCH] ftrace: Fix softlockup in ftrace_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250911144212.3d02a964@gandalf.local.home>
Date: Thu, 11 Sep 2025 14:42:12 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Vladimir Riabchun <ferr.lambarginio@...il.com>
Cc: 20250911104138.2830f60b@...dalf.local.home,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 mark.rutland@....com, mhiramat@...nel.org
Subject: Re: [PATCH] ftrace: Fix softlockup in ftrace_module_enable

On Thu, 11 Sep 2025 14:37:58 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> > Probably it may worth moving cond_resched under within_module check, but
> > before test_for_valid_rec call.  
> 
> Hmm, do modules even have weak functions? If they don't then that test is
> useless.

Doing a quick search, I see that they do :-/

drivers/tty/tty_ioctl.c:__weak int kernel_termios_to_user_termios(struct termios2 __user *u,

Looks like sparc can overwrite it. Thus, I'm guessing a module could add a
function and an arch may make it different. That means we still need this
for now.

Yeah, just send a v2 with the cond_resched() after the check for module.

-- Steve