| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250911-v6-16-topic-usb-onboard-dev-v4-5-1af288125d74@pengutronix.de>
Date: Thu, 11 Sep 2025 22:22:46 +0200
From: Marco Felsch <m.felsch@...gutronix.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
Matthias Kaehlcke <mka@...omium.org>, Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, kernel@...gutronix.de,
Marco Felsch <m.felsch@...gutronix.de>
Subject: [PATCH v4 5/5] usb: misc: onboard_dev: add hub downstream port
host vbus-supply handling
Some PCB designs don't use the dedicated USB hub port power GPIOs.
Instead they route the signals to the host. So the host is in charge to
power the VBUS supplies.
As first step the USB hub OF information is parsed and possible optional
vbus-supply regulators are added. This is done during the platform
driver probe() function.
Afterwards, during the usb driver probe() function and in case this is
an USB hub, the set/clear features hooks are registered via the new
usb_hub_register_port_feature_hooks().
After this registration all generic usb hub set/clear features calls are
passed to the onboard_dev driver too. This allows the driver to
en-/disable the regulators.
Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
---
drivers/usb/misc/onboard_usb_dev.c | 117 +++++++++++++++++++++++++++++++++++++
1 file changed, 117 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index 5b481876af1b2c10ce625fcf0fb8bfbe8905aa8c..1ceea75d30d320e5d2203c768b9641876ebd37ad 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -54,6 +54,12 @@ struct usbdev_node {
struct list_head list;
};
+struct onboard_dev_port_regulator {
+ struct regulator *vbus_supply;
+ unsigned int port;
+ struct list_head list;
+};
+
struct onboard_dev {
struct regulator_bulk_data supplies[MAX_SUPPLIES];
struct device *dev;
@@ -65,6 +71,7 @@ struct onboard_dev {
struct list_head udev_list;
struct mutex lock;
struct clk *clk;
+ struct list_head ext_vbus_supplies;
};
static int onboard_dev_get_regulators(struct onboard_dev *onboard_dev)
@@ -226,6 +233,71 @@ static int onboard_dev_add_usbdev(struct onboard_dev *onboard_dev,
return err;
}
+static int onboard_dev_port_power(struct onboard_dev *onboard_dev, int port1,
+ bool enable)
+{
+ struct onboard_dev_port_regulator *regulator;
+ struct regulator *vbus_supply = NULL;
+
+ list_for_each_entry(regulator, &onboard_dev->ext_vbus_supplies, list) {
+ if (regulator->port == port1) {
+ vbus_supply = regulator->vbus_supply;
+ break;
+ }
+ }
+
+ /* External supplies are optional, return no error */
+ if (!vbus_supply)
+ return 0;
+
+ if (enable)
+ return regulator_enable(vbus_supply);
+
+ return regulator_disable(vbus_supply);
+}
+
+static int onboard_dev_add_ext_vbus_supplies(struct onboard_dev *onboard_dev)
+{
+ struct device *dev = onboard_dev->dev;
+
+ if (!onboard_dev->pdata->is_hub)
+ return 0;
+
+ INIT_LIST_HEAD(&onboard_dev->ext_vbus_supplies);
+
+ for_each_child_of_node_scoped(dev->of_node, child) {
+ struct onboard_dev_port_regulator *regulator;
+ struct regulator *port_supply;
+ u32 port;
+
+ port_supply = devm_of_regulator_get_optional(dev, child, "vbus");
+ if (IS_ERR(port_supply)) {
+ if (PTR_ERR(port_supply) == -ENODEV)
+ continue;
+ return PTR_ERR(port_supply);
+ }
+
+ /*
+ * The VBUS of this downstream port is controlled by a host
+ * managed regulator
+ */
+ if (of_property_read_u32(child, "reg", &port)) {
+ dev_err(dev, "Failed to parse USB device reg property\n");
+ return -EINVAL;
+ }
+
+ regulator = devm_kzalloc(dev, sizeof(*regulator), GFP_KERNEL);
+ if (!regulator)
+ return -ENOMEM;
+
+ regulator->vbus_supply = port_supply;
+ regulator->port = port;
+ list_add(®ulator->list, &onboard_dev->ext_vbus_supplies);
+ }
+
+ return 0;
+}
+
static void onboard_dev_remove_usbdev(struct onboard_dev *onboard_dev,
const struct usb_device *udev)
{
@@ -460,6 +532,10 @@ static int onboard_dev_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(onboard_dev->reset_gpio),
"failed to get reset GPIO\n");
+ err = onboard_dev_add_ext_vbus_supplies(onboard_dev);
+ if (err)
+ return dev_err_probe(dev, err, "failed to parse port vbus supplies\n");
+
mutex_init(&onboard_dev->lock);
INIT_LIST_HEAD(&onboard_dev->udev_list);
@@ -573,6 +649,44 @@ static struct platform_driver onboard_dev_driver = {
#define VENDOR_ID_VIA 0x2109
#define VENDOR_ID_XMOS 0x20B1
+static int onboard_dev_port_feature(struct usb_device *udev, bool set,
+ int feature, int port1)
+{
+ struct device *dev = &udev->dev;
+ struct onboard_dev *onboard_dev = dev_get_drvdata(dev);
+
+ /*
+ * Check usb_hub_register_port_feature_hooks() if you want to extent
+ * the list of handled features. At the moment only power is synced
+ * after adding the hook.
+ */
+ switch (feature) {
+ case USB_PORT_FEAT_POWER:
+ return onboard_dev_port_power(onboard_dev, port1, set);
+ default:
+ return 0;
+ }
+}
+
+static int
+onboard_dev_set_port_feature(struct usb_device *udev, int feature, int port1)
+{
+ return onboard_dev_port_feature(udev, true, feature, port1);
+}
+
+static int
+onboard_dev_clear_port_feature(struct usb_device *udev, int feature, int port1)
+{
+ return onboard_dev_port_feature(udev, false, feature, port1);
+}
+
+static void
+onboard_dev_register_hub_hooks(struct usb_device *udev)
+{
+ usb_hub_register_port_feature_hooks(udev, onboard_dev_set_port_feature,
+ onboard_dev_clear_port_feature);
+}
+
/*
* Returns the onboard_dev platform device that is associated with the USB
* device passed as parameter.
@@ -632,6 +746,9 @@ static int onboard_dev_usbdev_probe(struct usb_device *udev)
dev_set_drvdata(dev, onboard_dev);
+ if (onboard_dev->pdata->is_hub)
+ onboard_dev_register_hub_hooks(udev);
+
err = onboard_dev_add_usbdev(onboard_dev, udev);
if (err)
return err;
--
2.47.3
Powered by blists - more mailing lists