linux-kernel - RE: [PATCH 5.10.y] e1000e: fix EEPROM length types for overflow checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898660189DDF668D00B1364FE509A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 11 Sep 2025 06:27:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Farber, Eliav" <farbere@...zon.com>, Greg KH <gregkh@...uxfoundation.org>
CC: "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>, "Nguyen,
 Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, "Lifshits,
 Vitaly" <vitaly.lifshits@...el.com>, "post@...aelkw.online"
	<post@...aelkw.online>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Chocron, Jonathan" <jonnyc@...zon.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 5.10.y] e1000e: fix EEPROM length types for overflow
 checks



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Farber, Eliav
> Sent: Thursday, September 11, 2025 8:14 AM
> To: Greg KH <gregkh@...uxfoundation.org>
> Cc: jesse.brandeburg@...el.com; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> Lifshits, Vitaly <vitaly.lifshits@...el.com>; post@...aelkw.online;
> intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Chocron, Jonathan <jonnyc@...zon.com>;
> stable@...r.kernel.org; Farber, Eliav <farbere@...zon.com>
> Subject: Re: [Intel-wired-lan] [PATCH 5.10.y] e1000e: fix EEPROM
> length types for overflow checks
> 

...

> >> diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c
> >> b/drivers/net/ethernet/intel/e1000e/ethtool.c
> >> index 4aca854783e2..584378291f3f 100644
> >> --- a/drivers/net/ethernet/intel/e1000e/ethtool.c
> >> +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c
> >> @@ -559,7 +559,7 @@ static int e1000_set_eeprom(struct net_device
> >> *netdev,  {
> >>       struct e1000_adapter *adapter = netdev_priv(netdev);
> >>       struct e1000_hw *hw = &adapter->hw;
> >> -     size_t total_len, max_len;
> >> +     u32 total_len, max_len;
I'd like to recommend adding a comment to prevent future regressions, like:
/* Use u32 to match types in check_add_overflow() with eeprom->offset and eeprom->len */
Anyway, it's good commit.
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>


...
> > Also, why is it not cc: stable@...r.kernel.org?
> Added to cc.
> 
> ---
> Regards, Eliav