linux-kernel - Re: [PATCH v7 0/3] dt-bindings: mfd: twl: Consolidate and fix TI TWL family bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911-dainty-penguin-of-fragrance-9b4cef@kuoka>
Date: Thu, 11 Sep 2025 08:35:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: andreas@...nade.info, lee@...nel.org, krzk+dt@...nel.org, 
	tony@...mide.com, robh@...nel.org, conor+dt@...nel.org, ukleinek@...nel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org, 
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v7 0/3] dt-bindings: mfd: twl: Consolidate and fix TI TWL
 family bindings

On Wed, Sep 10, 2025 at 06:07:01PM +0200, Jihed Chaibi wrote:
> This version addresses a final piece of feedback from Andreas to make
> the twl4030/twl6030-specific child nodes (audio, usb, keypad etc.)
> conditional by moving them out of the common block, which now only
> contains common properties (rtc, charger, pwm, pwmled..) ensuring
> the schema is fully accurate.
> 
> The complete dtbs_check for this binding is clean except for two
> warnings originating from pre-existing bugs in the OMAP DTS files,
> for which fixes have already been submitted separately [1][2].
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Acked-by: Uwe Kleine-König <ukleinek@...nel.org>
> 
> ---
> Changes in v7:
>   - (1/3): Moved twl4030/twl6030-specific child node definitions (audio,
>     usb etc.) into the conditional 'if/then' block to improve schema
>     accuracy.

Who asked for this? It's wrong code.

Best regards,
Krzysztof