linux-kernel - [PATCH v2] fs: expand dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250911065641.1564625-1-mjguzik@gmail.com>
Date: Thu, 11 Sep 2025 08:56:41 +0200
From: Mateusz Guzik <mjguzik@...il.com>
To: brauner@...nel.org
Cc: viro@...iv.linux.org.uk,
	jack@...e.cz,
	linux-kernel@...r.kernel.org,
	david@...morbit.com,
	linux-fsdevel@...r.kernel.org,
	Mateusz Guzik <mjguzik@...il.com>
Subject: [PATCH v2] fs: expand dump_inode()

This adds fs name and few fields from struct inode: i_mode, i_opflags,
i_flags, i_state and i_count.

All values printed raw, no attempt to pretty-print anything.

Compile tested on i386 and runtime tested on amd64.

Sample output:
[   23.121281] VFS_WARN_ON_INODE("crap") encountered for inode ffff9a1a83ce3660
               fs pipefs mode 10600 opflags 0x4 flags 0x0 state 0x38 count 0

Signed-off-by: Mateusz Guzik <mjguzik@...il.com>
---

v2:
- use 0x for hex values
- add i_count

generated against master, cosmetic changes are needed against the
vfs-6.18.inode.refcount.preliminaries branch.

 fs/inode.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/fs/inode.c b/fs/inode.c
index 01ebdc40021e..95fada5c45ea 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2911,10 +2911,18 @@ EXPORT_SYMBOL(mode_strip_sgid);
  *
  * TODO: add a proper inode dumping routine, this is a stub to get debug off the
  * ground.
+ *
+ * TODO: handle getting to fs type with get_kernel_nofault()?
+ * See dump_mapping() above.
  */
 void dump_inode(struct inode *inode, const char *reason)
 {
-       pr_warn("%s encountered for inode %px", reason, inode);
+	struct super_block *sb = inode->i_sb;
+
+	pr_warn("%s encountered for inode %px\n"
+		"fs %s mode %ho opflags 0x%hx flags 0x%x state 0x%x count %d\n",
+		reason, inode, sb->s_type->name, inode->i_mode, inode->i_opflags,
+		inode->i_flags, inode->i_state, atomic_read(&inode->i_count));
 }
 
 EXPORT_SYMBOL(dump_inode);
-- 
2.43.0