linux-kernel - Re: [PATCH v2 03/14] dt-bindings: iio: accel: bosch,bma220 change irq type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911-nostalgic-sturdy-markhor-57f87f@kuoka>
Date: Thu, 11 Sep 2025 09:33:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Petre Rodan <petre.rodan@...dimension.ro>
Cc: Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/14] dt-bindings: iio: accel: bosch,bma220 change
 irq type

On Wed, Sep 10, 2025 at 10:57:08AM +0300, Petre Rodan wrote:
> Set the interrupt type to rising edge instead of high level.
> 
> Quoting from the datasheet:
> 
>  "If at least one of the configured conditions applies, an interrupt
>  (logic ‘1’) is issued through the INT pin of the sensor."

I don't see how this explains/suggests raising edge.

> 
> The old code did not request an irq line via devm_request_threaded_irq()
> so there is no backward compatibility that would be affected by this
> change.

This sentence is irrelevant. You are changing only example, which has
zero impact.

Rewrite the subject and commit msg to accurately say this - it is only
example - because now you suggest you actually change something...

Best regards,
Krzysztof